MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 21:11:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-179871 Automatically use nullable annotations in constructor generation

Browse Source
This commit is contained in:
peter
2018-01-08 20:50:57 +01:00
parent 0d68a7724a
commit 9d1de0c271
4 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInsight/generation/GenerateConstructorHandler.java
View File

@@ -275,7 +275,7 @@ public class GenerateConstructorHandler extends GenerateMembersHandlerBase {
parmName = javaStyle.suggestUniqueVariableName(parmName, dummyConstructor, true);
PsiParameter parm = factory.createParameter(parmName, field.getType(), aClass);
NullableNotNullManager.getInstance(project).copyNotNullAnnotation(field, parm);
NullableNotNullManager.getInstance(project).copyNullableOrNotNullAnnotation(field, parm);
if (constructor.isVarArgs()) {
final PsiParameterList parameterList = constructor.getParameterList();

9
java/java-tests/testData/codeInsight/generateConstructor/afterNullableField.java Normal file
View File

@@ -0,0 +1,9 @@
import org.jetbrains.annotations.Nullable;
class C {
private @Nullable String s;
public C(@Nullable String s) {
this.s = s;
}
}

7
java/java-tests/testData/codeInsight/generateConstructor/beforeNullableField.java Normal file
View File

@@ -0,0 +1,7 @@
import org.jetbrains.annotations.Nullable;
class C {
private @Nullable String s;
<caret>
}

2
java/java-tests/testSrc/com/intellij/java/codeInsight/GenerateConstructorTest.java
View File

@@ -92,6 +92,8 @@ public class GenerateConstructorTest extends LightCodeInsightFixtureTestCase {
doTest();
}
public void testNullableField() { doTest(); }
private void doTest() {
doTest(false);
}