[tests] don't start test framework checks if framework is not attached (IDEA-285422)

GitOrigin-RevId: d356f61463159b8bbace12bc35a598e3211bfff0

java/java-impl/src/com/intellij/testIntegration/JavaTestFramework.java

@@ -1,4 +1,4 @@
-// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
 package com.intellij.testIntegration;
 
 import com.intellij.codeInsight.daemon.impl.quickfix.OrderEntryFix;
@@ -17,7 +17,10 @@ import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.*;
 import com.intellij.psi.search.GlobalSearchScope;
+import com.intellij.psi.util.CachedValueProvider;
+import com.intellij.psi.util.CachedValuesManager;
 import com.intellij.util.IncorrectOperationException;
+import com.intellij.util.containers.ConcurrentFactoryMap;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -25,6 +28,7 @@ import org.jetbrains.concurrency.Promise;
 import org.jetbrains.concurrency.Promises;
 
 import java.util.Collections;
+import java.util.concurrent.ConcurrentMap;
 
 public abstract class JavaTestFramework implements TestFramework {
   @Override
@@ -50,9 +54,22 @@ public abstract class JavaTestFramework implements TestFramework {
 
   protected abstract String getMarkerClassFQName();
 
+  /**
+   * Return {@code true} iff {@link #getMarkerClassFQName()} can be found in the resolve scope of {@code clazz} 
+   */
+  protected boolean isFrameworkAvailable(@NotNull PsiElement clazz) {
+    return CachedValuesManager.<ConcurrentMap<String, PsiClass>>getCachedValue(clazz, () -> {
+      var project = clazz.getProject();
+      return new CachedValueProvider.Result<>(
+        ConcurrentFactoryMap.createMap(
+          markerInterfaceName -> JavaPsiFacade.getInstance(project).findClass(markerInterfaceName, clazz.getResolveScope())),
+        ProjectRootManager.getInstance(project));
+    }).get(getMarkerClassFQName()) != null;
+  }
+  
   @Override
   public boolean isTestClass(@NotNull PsiElement clazz) {
-    return clazz instanceof PsiClass && isTestClass((PsiClass)clazz, false);
+    return clazz instanceof PsiClass && isFrameworkAvailable(clazz) && isTestClass((PsiClass)clazz, false);
   }
 
   @Override
@@ -72,7 +89,10 @@ public abstract class JavaTestFramework implements TestFramework {
   @Override
   @Nullable
   public PsiElement findSetUpMethod(@NotNull PsiElement clazz) {
-    return clazz instanceof PsiClass ? findSetUpMethod((PsiClass)clazz) : null;
+    if (clazz instanceof PsiClass && isFrameworkAvailable(clazz)) {
+      return findSetUpMethod((PsiClass)clazz);
+    }
+    return null;
   }
 
   @Nullable
@@ -81,7 +101,10 @@ public abstract class JavaTestFramework implements TestFramework {
   @Override
   @Nullable
   public PsiElement findTearDownMethod(@NotNull PsiElement clazz) {
-    return clazz instanceof PsiClass ? findTearDownMethod((PsiClass)clazz) : null;
+    if (clazz instanceof PsiClass && isFrameworkAvailable(clazz)) {
+      return findTearDownMethod((PsiClass)clazz);
+    }
+    return null;
   }
 
   @Nullable
@@ -90,7 +113,10 @@ public abstract class JavaTestFramework implements TestFramework {
   @Nullable
   @Override
   public PsiElement findBeforeClassMethod(@NotNull PsiElement clazz) {
-    return clazz instanceof PsiClass ? findBeforeClassMethod((PsiClass)clazz) : null;
+    if (clazz instanceof PsiClass && isFrameworkAvailable(clazz)) {
+      return findBeforeClassMethod((PsiClass)clazz);
+    }
+    return null;
   }
 
   @Nullable
@@ -101,7 +127,10 @@ public abstract class JavaTestFramework implements TestFramework {
   @Nullable
   @Override
   public PsiElement findAfterClassMethod(@NotNull PsiElement clazz) {
-    return clazz instanceof PsiClass ? findAfterClassMethod((PsiClass)clazz) : null;
+    if (clazz instanceof PsiClass && isFrameworkAvailable(clazz)) {
+      return findAfterClassMethod((PsiClass)clazz);
+    }
+    return null;
   }
 
   @Nullable
@@ -111,7 +140,10 @@ public abstract class JavaTestFramework implements TestFramework {
 
   @Override
   public PsiElement findOrCreateSetUpMethod(@NotNull PsiElement clazz) throws IncorrectOperationException {
-    return clazz instanceof PsiClass ? findOrCreateSetUpMethod((PsiClass)clazz) : null;
+    if (clazz instanceof PsiClass && isFrameworkAvailable(clazz)) {
+      return findOrCreateSetUpMethod((PsiClass)clazz);
+    }
+    return null;
   }
 
   @Override

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/moveInitializerToSetUp/beforeTestNG.java

@@ -1,4 +1,4 @@
-// "Move initializer to setUp method" "true"
+// "Move initializer to setUp method" "false"
 public class X {
   <caret>int i = 7;
 

plugins/InspectionGadgets/test/com/siyeh/igtest/initialization/field/InstanceVariableInitialization.java

@@ -107,7 +107,7 @@ class WithNullable {
 
 class JUnit5Test {
 
-  private String myField;
+  private String <warning descr="Instance field 'myField' may not be initialized during object construction">myField</warning>;
 
   @org.<error descr="Cannot resolve symbol 'junit'">junit</error>.jupiter.api.BeforeEach
   void init() {