MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

RegExp: redundantly escaped 'u' not correctly unescaped (IDEA-208559)

Browse Source
This commit is contained in:
Bas Leijdekkers
2019-03-25 15:40:38 +01:00
parent 79f0949c92
commit 971ba07c24
2 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RegExpSupport/src/org/intellij/lang/regexp/psi/impl/RegExpCharImpl.java
+1 -1
View File
@@ -106,7 +106,7 @@ public class RegExpCharImpl extends RegExpElementImpl implements RegExpChar {
}
return length == 4 ? parseNumber(s, 2, 16) : -1;
case 'u':
if (length <= 2) return -1;
if (length <= 2) return 'u';
if (s.charAt(2) == '{') {
final char c = s.charAt(length - 1);
return (c != '}') ? -1 : parseNumber(s, 3, 16);
RegExpSupport/test/org/intellij/lang/regexp/inspection/RedundantEscapeInspectionTest.java
+8 -15
View File
@@ -1,21 +1,9 @@
/*
* Copyright 2000-2017 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package org.intellij.lang.regexp.inspection;
import com.intellij.codeInspection.LocalInspectionTool;
import org.intellij.lang.regexp.RegExpFileType;
import org.intellij.lang.regexp.ecmascript.EcmaScriptRegexpLanguage;
import org.jetbrains.annotations.NotNull;
/**
@@ -36,6 +24,11 @@ public class RedundantEscapeInspectionTest extends RegExpInspectionTestCase {
highlightTest("a<warning descr=\"Redundant character escape '\\ ' in RegExp\">\\ </warning>b<warning descr=\"Redundant character escape '\\ ' in RegExp\">\\ </warning>c");
}
public void testEscapedU() {
quickfixTest("<warning descr=\"Redundant character escape '\\u' in RegExp\">\\u</warning>", "u", "Remove redundant escape",
new RegExpFileType(EcmaScriptRegexpLanguage.INSTANCE));
}
@NotNull
@Override
protected LocalInspectionTool getInspection() {