MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[groovy] do as less comparisons as possible when filtering methods in MethodResolverProcessor

Browse Source
This commit is contained in:
Daniil Ovchinnikov
2015-12-10 16:48:00 +03:00
parent 4266110353
commit 95e4dc18a5
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/resolve/processors/MethodResolverProcessor.java
+9 -5
View File
@@ -203,20 +203,24 @@ public class MethodResolverProcessor extends ResolverProcessor<GroovyMethodResul
* -1 if first is more preferable
*/
private int compareMethods(@NotNull GroovyMethodResult result1, @NotNull GroovyMethodResult result2) {
PsiMethod method1 = result1.getElement();
PsiMethod method2 = result2.getElement();
final PsiMethod method1 = result1.getElement();
final PsiMethod method2 = result2.getElement();
if (!method1.getName().equals(method2.getName())) return 0;
if (secondMethodIsPreferable(result1, result2)) {
if (secondMethodIsPreferable(result2, result1)) {
boolean firstIsPreferable = secondMethodIsPreferable(result2, result1);
boolean secondIsPreferable = secondMethodIsPreferable(result1, result2);
if (secondIsPreferable) {
if (firstIsPreferable) {
if (method2 instanceof GrGdkMethod && !(method1 instanceof GrGdkMethod)) {
return -1;
}
}
return 1;
}
if (secondMethodIsPreferable(result2, result1)) {
if (firstIsPreferable) {
return -1;
}