MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

allow duplicate throws (IDEADEV-41667)

Browse Source
This commit is contained in:
anna
2009-11-27 21:33:36 +03:00
parent d12aba123e
commit 95b588371d
4 changed files with 31 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/java-impl/src/com/intellij/codeInspection/javaDoc/JavaDocLocalInspection.java
View File

@@ -96,6 +96,7 @@ public class JavaDocLocalInspection extends BaseLocalInspectionTool {
@NonNls public Options FIELD_OPTIONS = new Options("none", "");
public boolean IGNORE_DEPRECATED = false;
public boolean IGNORE_JAVADOC_PERIOD = true;
public boolean IGNORE_DUPLICATED_THROWS = false;
public String myAdditionalJavadocTags = "";
private static final Logger LOG = Logger.getInstance("com.intellij.codeInspection.javaDoc.JavaDocLocalInspection");
@@ -242,6 +243,15 @@ public class JavaDocLocalInspection extends BaseLocalInspectionTool {
}
});
add(periodCheckBox, gc);
final JCheckBox ignoreDuplicateThrowsCheckBox = new JCheckBox("Ignore duplicate throws tag",
IGNORE_DUPLICATED_THROWS);
ignoreDuplicateThrowsCheckBox.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
IGNORE_DUPLICATED_THROWS = ignoreDuplicateThrowsCheckBox.isSelected();
}
});
add(ignoreDuplicateThrowsCheckBox, gc);
}
public FieldPanel createAdditionalJavadocTagsPanel(){
@@ -1012,7 +1022,7 @@ public class JavaDocLocalInspection extends BaseLocalInspectionTool {
return false;
}
private static void checkDuplicateTags(final PsiDocTag[] tags,
private void checkDuplicateTags(final PsiDocTag[] tags,
ArrayList<ProblemDescriptor> problems,
final InspectionManager manager, boolean isOnTheFly) {
Set<String> documentedParamNames = null;
@@ -1037,7 +1047,7 @@ public class JavaDocLocalInspection extends BaseLocalInspectionTool {
}
}
}
else if ("throws".equals(tag.getName()) || "exception".equals(tag.getName())) {
else if (!IGNORE_DUPLICATED_THROWS && ("throws".equals(tag.getName()) || "exception".equals(tag.getName()))) {
PsiDocTagValue value = tag.getValueElement();
if (value != null) {
final PsiElement firstChild = value.getFirstChild();

4
java/java-tests/testData/inspection/javaDocInspection/ignoreDuplicateThrows/expected.xml Normal file
View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
</problems>

9
java/java-tests/testData/inspection/javaDocInspection/ignoreDuplicateThrows/src/Test.java Normal file
View File

@@ -0,0 +1,9 @@
class Test {
/**
*@throws ArrayIndexOutOfBoundsException in some case
*@throws ArrayIndexOutOfBoundsException and in some other case
*/
void foo() throws ArrayIndexOutOfBoundsException {
}
}

6
java/java-tests/testSrc/com/intellij/codeInspection/JavaDocInspectionTest.java
View File

@@ -56,4 +56,10 @@ public class JavaDocInspectionTest extends InspectionTestCase {
public void testGenericsParams() throws Exception {
doTest();
}
public void testIgnoreDuplicateThrows() throws Exception {
final JavaDocLocalInspection inspection = new JavaDocLocalInspection();
inspection.IGNORE_DUPLICATED_THROWS = true;
doTest("javaDocInspection/" + getTestName(true), inspection);
}
}