PY-24817 Fixed: False positive: Method may be 'static' when docstring is present

Update PyMethodMayBeStaticInspection to consider more methods as empty ones.

python/src/com/jetbrains/python/inspections/PyMethodMayBeStaticInspection.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2016 JetBrains s.r.o.
+ * Copyright 2000-2017 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -78,10 +78,7 @@ public class PyMethodMayBeStaticInspection extends PyInspection {
       if (!attributes.isEmpty()) return;
       if (isTestElement(node)) return;
 
-      final PyStatementList statementList = node.getStatementList();
-      final PyStatement[] statements = statementList.getStatements();
-
-      if (statements.length == 1 && statements[0] instanceof PyPassStatement) return;
+      if (PyUtil.isEmptyFunction(node)) return;
 
       final PyParameter[] parameters = node.getParameterList().getParameters();
 

python/testData/inspections/PyMethodMayBeStaticInspection/documentedEmpty.py

@@ -0,0 +1,4 @@
+class A:
+    def foo(self):
+        """Do something"""
+        pass

python/testSrc/com/jetbrains/python/inspections/PyMethodMayBeStaticInspectionTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2016 JetBrains s.r.o.
+ * Copyright 2000-2017 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -105,6 +105,11 @@ public class PyMethodMayBeStaticInspectionTest extends PyTestCase {
     runWithLanguageLevel(LanguageLevel.PYTHON30, () -> doTest());
   }
 
+  // PY-24817
+  public void testDocumentedEmpty() {
+    doTest();
+  }
+
   private void doTest() {
     myFixture.configureByFile(getTestName(true) + ".py");
     myFixture.enableInspections(PyMethodMayBeStaticInspection.class);