IDEA-61180: When file is renamed, breakpoint file path is not updated

platform/platform-impl/src/com/intellij/openapi/vfs/VirtualFileUrlChangeAdapter.java

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.openapi.vfs;
+
+/**
+ * @author nik
+ */
+public abstract class VirtualFileUrlChangeAdapter extends VirtualFileAdapter {
+  @Override
+  public void fileMoved(VirtualFileMoveEvent event) {
+    String oldUrl = event.getOldParent().getUrl() + "/" + event.getFileName();
+    String newUrl = event.getNewParent().getUrl() + "/" + event.getFileName();
+    fileUrlChanged(oldUrl, newUrl);
+  }
+
+  protected abstract void fileUrlChanged(String oldUrl, String newUrl);
+
+  public void propertyChanged(VirtualFilePropertyEvent event) {
+    if (VirtualFile.PROP_NAME.equals(event.getPropertyName())) {
+      final VirtualFile parent = event.getFile().getParent();
+      if (parent != null) {
+        final String parentUrl = parent.getUrl();
+        fileUrlChanged(parentUrl + "/" + event.getOldValue(), parentUrl + "/" + event.getNewValue());
+      }
+    }
+  }
+}

platform/xdebugger-impl/src/com/intellij/xdebugger/impl/breakpoints/XLineBreakpointImpl.java

@@ -295,6 +295,14 @@ public class XLineBreakpointImpl<P extends XBreakpointProperties> extends XBreak
     }
   }
 
+  public void setFileUrl(final String newUrl) {
+    if (!Comparing.equal(getFileUrl(), newUrl)) {
+      myState.setFileUrl(newUrl);
+      mySourcePosition = null;
+      fireBreakpointChanged();
+    }
+  }
+
   private void setLine(final int line) {
     if (getLine() != line) {
       myState.setLine(line);

platform/xdebugger-impl/src/com/intellij/xdebugger/impl/breakpoints/XLineBreakpointManager.java

@@ -36,7 +36,8 @@ import com.intellij.openapi.fileEditor.TextEditor;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.startup.StartupManager;
 import com.intellij.openapi.util.Disposer;
-import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.openapi.util.io.FileUtil;
+import com.intellij.openapi.vfs.*;
 import com.intellij.psi.PsiDocumentManager;
 import com.intellij.util.containers.BidirectionalMap;
 import com.intellij.util.ui.update.MergingUpdateQueue;
@@ -82,6 +83,17 @@ public class XLineBreakpointManager {
           myDependentBreakpointManager.removeListener(myDependentBreakpointListener);
         }
       });
+      VirtualFileManager.getInstance().addVirtualFileListener(new VirtualFileUrlChangeAdapter() {
+        @Override
+        protected void fileUrlChanged(String oldUrl, String newUrl) {
+          for (XLineBreakpointImpl breakpoint : myBreakpoints.keySet()) {
+            final String url = breakpoint.getFileUrl();
+            if (FileUtil.startsWith(url, oldUrl)) {
+              breakpoint.setFileUrl(newUrl + url.substring(oldUrl.length()));
+            }
+          }
+        }
+      }, project);
     }
     myBreakpointsUpdateQueue = new MergingUpdateQueue("XLine breakpoints", 300, true, null, project);
 

platform/xdebugger-impl/testSrc/com/intellij/xdebugger/UpdateBreakpointsAfterRenameTest.java

@@ -0,0 +1,81 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.xdebugger;
+
+import com.intellij.openapi.util.io.FileUtil;
+import com.intellij.openapi.vfs.LocalFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.testFramework.PlatformTestCase;
+import com.intellij.xdebugger.breakpoints.XBreakpointManager;
+import com.intellij.xdebugger.breakpoints.XLineBreakpoint;
+
+import java.io.File;
+
+/**
+ * @author nik
+ */
+public class UpdateBreakpointsAfterRenameTest extends PlatformTestCase {
+  private File myTempDirectory;
+
+  public UpdateBreakpointsAfterRenameTest() {
+    initPlatformLangPrefix();
+  }
+
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+    myTempDirectory = createTempDirectory();
+  }
+
+  public void testRenameFile() throws Exception {
+    final VirtualFile file = createFile("file.txt");
+    XLineBreakpoint<?> b = putBreakpoint(file);
+    file.rename(this, "file2.txt");
+    assertTrue(b.getFileUrl().endsWith("file2.txt"));
+    assertSame(b, getBreakpointManager().findBreakpointAtLine(XDebuggerTestCase.MY_LINE_BREAKPOINT_TYPE, file, 0));
+  }
+
+  public void testMoveFile() throws Exception {
+    final VirtualFile file = createFile("dir/a.txt");
+    final VirtualFile targetDir = createFile("dir2/b.txt").getParent();
+    final XLineBreakpoint<?> b = putBreakpoint(file);
+    file.move(this, targetDir);
+    assertTrue(b.getFileUrl().endsWith("dir2/a.txt"));
+  }
+
+  public void testRenameParentDir() throws Exception {
+    final VirtualFile file = createFile("dir/x.txt");
+    final XLineBreakpoint<?> b = putBreakpoint(file);
+    file.getParent().rename(this, "dir2");
+    assertTrue(b.getFileUrl().endsWith("dir2/x.txt"));
+  }
+
+  private XLineBreakpoint<?> putBreakpoint(final VirtualFile file) {
+    return getBreakpointManager().addLineBreakpoint(XDebuggerTestCase.MY_LINE_BREAKPOINT_TYPE, file.getUrl(), 0, null);
+  }
+
+  private VirtualFile createFile(String path) {
+    final File ioFile = new File(myTempDirectory, FileUtil.toSystemDependentName(path));
+    FileUtil.createIfDoesntExist(ioFile);
+    final VirtualFile virtualFile = LocalFileSystem.getInstance().refreshAndFindFileByIoFile(ioFile);
+    assertNotNull(virtualFile);
+    return virtualFile;
+  }
+
+  public XBreakpointManager getBreakpointManager() {
+    return XDebuggerManager.getInstance(myProject).getBreakpointManager();
+  }
+}

platform/xdebugger-impl/testSrc/com/intellij/xdebugger/XDebuggerTestCase.java

@@ -33,7 +33,7 @@ import org.picocontainer.MutablePicoContainer;
  * @author nik
  */
 public abstract class XDebuggerTestCase extends PlatformLiteFixture {
-  protected static final MyLineBreakpointType MY_LINE_BREAKPOINT_TYPE = new MyLineBreakpointType();
+  public static final MyLineBreakpointType MY_LINE_BREAKPOINT_TYPE = new MyLineBreakpointType();
   protected static final MySimpleBreakpointType MY_SIMPLE_BREAKPOINT_TYPE = new MySimpleBreakpointType();
 
   @Override
@@ -46,10 +46,14 @@ public abstract class XDebuggerTestCase extends PlatformLiteFixture {
 
     MutablePicoContainer container = getApplication().getPicoContainer();
     registerComponentImplementation(container, EditorFactory.class, MockEditorFactory.class);
-    registerComponentImplementation(container, VirtualFileManager.class, MockVirtualFileManager.class);
+    registerVfsComponents(container);
     registerComponentImplementation(container, HttpFileSystem.class, HttpFileSystemImpl.class);
   }
 
+  protected void registerVfsComponents(MutablePicoContainer container) {
+    registerComponentImplementation(container, VirtualFileManager.class, MockVirtualFileManager.class);
+  }
+
   public static class MyLineBreakpointType extends XLineBreakpointType<MyBreakpointProperties> {
     public MyLineBreakpointType() {
       super("testLine", "239");

platform/xdebugger-impl/xdebugger-impl.iml

@@ -12,6 +12,9 @@
     <orderEntry type="module" module-name="lang-impl" />
     <orderEntry type="module" module-name="testFramework" scope="TEST" />
     <orderEntry type="library" name="Guava" level="project" />
+    <orderEntry type="module" module-name="platform-resources" />
+    <orderEntry type="module" module-name="dom-impl" scope="TEST" />
+    <orderEntry type="module" module-name="xml" scope="TEST" />
   </component>
 </module>