MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

Test and comment for IDEA-176340 "Optional.isPresent not highlighted"

Browse Source 
Actually was fixed in 0234c70
This commit is contained in:
Tagir Valeev
2017-07-21 17:12:02 +07:00
parent f290cffefc
commit 926a541520
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInspection/OptionalIsPresentInspection.java
View File

@@ -194,6 +194,8 @@ public class OptionalIsPresentInspection extends BaseJavaBatchLocalInspectionToo
if (!hasOptionalReference.get() || !(lambdaCandidate instanceof PsiExpression)) return ProblemType.INFO;
PsiExpression expression = (PsiExpression)lambdaCandidate;
if (falseExpression != null && NullnessUtil.getExpressionNullness(expression) != Nullness.NOT_NULL) {
// falseExpression == null is "consumer" case (to be replaced with ifPresent()),
// in this case we don't care about expression nullness
return ProblemType.INFO;
}
return ProblemType.WARNING;

4
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/optionalIsPresent/afterConsumerField.java
View File

@@ -1,4 +1,4 @@
// "Replace Optional.isPresent() condition with functional style expression" "true"
// "Replace Optional.isPresent() condition with functional style expression" "GENERIC_ERROR_OR_WARNING"
import java.util.*;
@@ -6,6 +6,6 @@ public class Main {
String myString;
public void testOptional(Optional<String> str) {
str.ifPresent(s -> myString = s);
str.ifPresent(s -> myString = s.isEmpty() ? null : s);
}
}

4
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/optionalIsPresent/beforeConsumerField.java
View File

@@ -1,4 +1,4 @@
// "Replace Optional.isPresent() condition with functional style expression" "true"
// "Replace Optional.isPresent() condition with functional style expression" "GENERIC_ERROR_OR_WARNING"
import java.util.*;
@@ -7,7 +7,7 @@ public class Main {
public void testOptional(Optional<String> str) {
if (str.isPrese<caret>nt()) {
myString = str.get();
myString = str.get().isEmpty() ? null : str.get();
}
}
}