MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

ComparisonToNaNInspection: support >=, >, <, <= comparisons IDEA-193102

Browse Source
This commit is contained in:
Tagir Valeev
2018-06-04 16:39:47 +07:00
parent 2c8a151869
commit 8fa99ba910
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/ComparisonToNaNInspection.java
+6 -5
View File
@@ -43,11 +43,11 @@ public class ComparisonToNaNInspection extends BaseInspection {
public String buildErrorString(Object... infos) {
final PsiBinaryExpression comparison = (PsiBinaryExpression)infos[0];
final IElementType tokenType = comparison.getOperationTokenType();
if (tokenType.equals(JavaTokenType.EQEQ)) {
return InspectionGadgetsBundle.message("comparison.to.nan.problem.descriptor1");
if (!tokenType.equals(JavaTokenType.NE)) {
return InspectionGadgetsBundle.message("comparison.to.nan.problem.descriptor2");
}
else {
return InspectionGadgetsBundle.message("comparison.to.nan.problem.descriptor2");
return InspectionGadgetsBundle.message("comparison.to.nan.problem.descriptor1");
}
}
@@ -58,7 +58,8 @@ public class ComparisonToNaNInspection extends BaseInspection {
@Override
public InspectionGadgetsFix buildFix(Object... infos) {
return new ComparisonToNaNFix();
final PsiBinaryExpression comparison = (PsiBinaryExpression)infos[0];
return ComparisonUtils.isEqualityComparison(comparison) ? new ComparisonToNaNFix() : null;
}
private static class ComparisonToNaNFix extends InspectionGadgetsFix {
@@ -114,7 +115,7 @@ public class ComparisonToNaNInspection extends BaseInspection {
@Override
public void visitBinaryExpression(@NotNull PsiBinaryExpression expression) {
super.visitBinaryExpression(expression);
if (!ComparisonUtils.isEqualityComparison(expression)) {
if (!ComparisonUtils.isComparison(expression)) {
return;
}
final PsiExpression lhs = expression.getLOperand();