IJPL-185469 Move TerminalFeedbackAction to the frontend

It was a bad idea to have it in a different module to begin with.

An extra dependency on the feedback module had to be added
to resolve the supertype and extensions.

(cherry picked from commit 8dcdae2e862aac9470cf17b08fc8938fd476928a)

IJ-CR-161379

GitOrigin-RevId: 435eae0fb3bfc029de46663d21f3842ed0d13079
This commit is contained in:
Sergei Tachenov
2025-04-30 14:34:56 +03:00
committed by intellij-monorepo-bot
parent 43972dfe0a
commit 8fa3583ba2
4 changed files with 7 additions and 11 deletions

View File

@@ -52,6 +52,7 @@
<orderEntry type="module" module-name="intellij.platform.indexing" />
<orderEntry type="module" module-name="intellij.platform.lang.impl" />
<orderEntry type="module" module-name="intellij.platform.ide.ui" />
<orderEntry type="module" module-name="intellij.platform.feedback" />
<orderEntry type="module" module-name="intellij.platform.testFramework" scope="TEST" />
</component>
</module>

View File

@@ -66,7 +66,7 @@
<group id="Terminal.ToolWindowActions">
<reference ref="Terminal.Engine"/>
<action id="Terminal.Settings" class="com.intellij.terminal.frontend.action.TerminalSettingsAction" icon="AllIcons.General.Settings"/>
<action id="Terminal.Feedback" class="org.jetbrains.plugins.terminal.action.TerminalFeedbackAction" />
<action id="Terminal.Feedback" class="com.intellij.terminal.frontend.action.TerminalFeedbackAction" />
</group>
<group id="Terminal.OutputContextMenu">

View File

@@ -1,20 +1,14 @@
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.plugins.terminal.action
package com.intellij.terminal.frontend.action
import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.remoting.ActionRemoteBehaviorSpecification
import com.intellij.openapi.project.DumbAwareAction
import com.intellij.platform.feedback.impl.state.CommonFeedbackSurveyService
import com.intellij.platform.feedback.isSuitableToShowByExplicitUserAction
import com.intellij.platform.feedback.showFeedbackDialog
import org.jetbrains.annotations.ApiStatus
import org.jetbrains.plugins.terminal.TerminalEngine
import org.jetbrains.plugins.terminal.TerminalOptionsProvider
import org.jetbrains.plugins.terminal.block.feedback.ReworkedTerminalSurveyConfig
@ApiStatus.Internal
class TerminalFeedbackAction : DumbAwareAction(), ActionRemoteBehaviorSpecification.Frontend {
internal class TerminalFeedbackAction : DumbAwareAction(), ActionRemoteBehaviorSpecification.Frontend {
override fun getActionUpdateThread(): ActionUpdateThread = ActionUpdateThread.BGT
override fun update(e: AnActionEvent) {
@@ -26,4 +20,4 @@ class TerminalFeedbackAction : DumbAwareAction(), ActionRemoteBehaviorSpecificat
val project = e.project ?: return
ReworkedTerminalSurveyConfig.showFeedbackDialog(project, forTest = false)
}
}
}

View File

@@ -57,7 +57,8 @@ internal class ReworkedTerminalFeedbackSurvey : FeedbackSurvey() {
override val feedbackSurveyType: FeedbackSurveyType<*> = InIdeFeedbackSurveyType(ReworkedTerminalSurveyConfig)
}
internal object ReworkedTerminalSurveyConfig : InIdeFeedbackSurveyConfig {
@ApiStatus.Internal
object ReworkedTerminalSurveyConfig : InIdeFeedbackSurveyConfig {
override val surveyId: String = "reworked_terminal"
override fun createFeedbackDialog(project: Project, forTest: Boolean): BlockBasedFeedbackDialog<out SystemDataJsonSerializable> {