MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

allow common quick fixes in IG

Browse Source
This commit is contained in:
anna
2012-07-13 19:08:55 +02:00
parent f65c74c073
commit 8eddfd2d87
2 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/BaseInspection.java
+3 -2
View File
@@ -17,6 +17,7 @@ package com.siyeh.ig;
import com.intellij.codeInspection.BaseJavaLocalInspectionTool;
import com.intellij.codeInspection.LocalInspectionToolSession;
import com.intellij.codeInspection.LocalQuickFix;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.util.text.StringUtil;
@@ -76,12 +77,12 @@ public abstract class BaseInspection extends BaseJavaLocalInspectionTool {
}
@Nullable
protected InspectionGadgetsFix buildFix(Object... infos) {
protected LocalQuickFix buildFix(Object... infos) {
return null;
}
@NotNull
protected InspectionGadgetsFix[] buildFixes(Object... infos) {
protected LocalQuickFix[] buildFixes(Object... infos) {
return InspectionGadgetsFix.EMPTY_ARRAY;
}
plugins/InspectionGadgets/src/com/siyeh/ig/BaseInspectionVisitor.java
+15 -10
View File
@@ -15,6 +15,7 @@
*/
package com.siyeh.ig;
import com.intellij.codeInspection.LocalQuickFix;
import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.openapi.util.TextRange;
@@ -183,9 +184,11 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
if (location.getTextLength() == 0 && !(location instanceof PsiFile)) {
return;
}
final InspectionGadgetsFix[] fixes = createFixes(infos);
for (InspectionGadgetsFix fix : fixes) {
fix.setOnTheFly(onTheFly);
final LocalQuickFix[] fixes = createFixes(infos);
for (LocalQuickFix fix : fixes) {
if (fix instanceof InspectionGadgetsFix) {
((InspectionGadgetsFix)fix).setOnTheFly(onTheFly);
}
}
final String description = inspection.buildErrorString(infos);
holder.registerProblem(location, description, highlightType, fixes);
@@ -196,9 +199,11 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
if (location.getTextLength() == 0 || length == 0) {
return;
}
final InspectionGadgetsFix[] fixes = createFixes(infos);
for (InspectionGadgetsFix fix : fixes) {
fix.setOnTheFly(onTheFly);
final LocalQuickFix[] fixes = createFixes(infos);
for (LocalQuickFix fix : fixes) {
if (fix instanceof InspectionGadgetsFix) {
((InspectionGadgetsFix)fix).setOnTheFly(onTheFly);
}
}
final String description = inspection.buildErrorString(infos);
final TextRange range = new TextRange(offset, offset + length);
@@ -206,19 +211,19 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
}
@NotNull
private InspectionGadgetsFix[] createFixes(Object... infos) {
private LocalQuickFix[] createFixes(Object... infos) {
if (!onTheFly && inspection.buildQuickFixesOnlyForOnTheFlyErrors()) {
return InspectionGadgetsFix.EMPTY_ARRAY;
}
final InspectionGadgetsFix[] fixes = inspection.buildFixes(infos);
final LocalQuickFix[] fixes = inspection.buildFixes(infos);
if (fixes.length > 0) {
return fixes;
}
final InspectionGadgetsFix fix = inspection.buildFix(infos);
final LocalQuickFix fix = inspection.buildFix(infos);
if (fix == null) {
return InspectionGadgetsFix.EMPTY_ARRAY;
}
return new InspectionGadgetsFix[]{fix};
return new LocalQuickFix[]{fix};
}
@Override