MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PointlessNullCheckInspection: don't pass nulls into isReferenceTo

Browse Source
This commit is contained in:
peter
2018-08-17 15:14:47 +02:00
parent 044585698b
commit 8db06b1907
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/PointlessNullCheckInspection.java
+2 -2
View File
@@ -207,7 +207,7 @@ public class PointlessNullCheckInspection extends BaseInspection {
final PsiVariable variable = tryCast(explicitCheckReference.resolve(), PsiVariable.class);
if (variable == null) return false;
final PsiReferenceExpression implicitCheckReference = getReferenceFromImplicitNullCheckExpression(implicitCheckCandidate);
if (implicitCheckReference == null || !implicitCheckReference.isReferenceTo(variable)) return false;
if (implicitCheckReference == null || variable == null || !implicitCheckReference.isReferenceTo(variable)) return false;
if (isVariableUsed(operands, i, j, variable)) return false;
registerError(binaryExpression, binaryExpression, implicitCheckReference);
return true;
@@ -288,7 +288,7 @@ public class PointlessNullCheckInspection extends BaseInspection {
if (variable == null) return null;
for (int i = 1, operandsLength = operands.length; i < operandsLength; i++) {
final PsiReferenceExpression reference2 = getReferenceFromImplicitNullCheckExpression(operands[i]);
if (reference2 == null || !reference2.isReferenceTo(variable)) {
if (reference2 == null || variable == null || !reference2.isReferenceTo(variable)) {
return null;
}
}