IDEA-208428 plugin.xml: should include "Jetbrains" as one of vendors false positives (Android-*)

This commit is contained in:
Yann Cébron
2019-03-05 17:44:28 +01:00
parent f956eb5162
commit 8da0b3f492
3 changed files with 16 additions and 0 deletions

View File

@@ -208,6 +208,13 @@ public class PluginXmlDomInspection extends BasicDomElementsInspection<IdeaPlugi
if (!hasRealPluginId(ideaPlugin)) return;
String id = ideaPlugin.getId().getStringValue();
if (id != null &&
(StringUtil.startsWith(id, "com.android.") ||
id.equals("org.jetbrains.android"))) {
return;
}
XmlTag xmlTag = ideaPlugin.getXmlTag();
if (xmlTag == null) return;

View File

@@ -0,0 +1,5 @@
<idea-plugin>
<id>com.android.something</id>
<version>1</version>
<vendor>JB is not required due to ID</vendor>
</idea-plugin>

View File

@@ -397,6 +397,10 @@ class PluginXmlFunctionalTest extends JavaCodeInsightFixtureTestCase {
testHighlightingInIdeaProject("pluginWithJetBrainsAndMeAsVendor.xml")
}
void testPluginXmlInIdeaProjectWithAndroidId() {
testHighlightingInIdeaProject("pluginWithAndroidIdVendor.xml")
}
void testSpecifyJetBrainsAsVendorQuickFix() {
PsiUtil.markAsIdeaProject(project, true)
try {