MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 21:11:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

lambda: do not suggest to replace anonymous with lambda when this/super exist in body (IDEA-91055)

Browse Source
This commit is contained in:
Anna Kozlova
2012-09-06 13:27:31 +04:00
parent bf348df986
commit 8d4ef8b54e
2 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
java/java-impl/src/com/intellij/codeInspection/AnonymousCanBeLambdaInspection.java
View File

@@ -77,19 +77,29 @@ public class AnonymousCanBeLambdaInspection extends BaseJavaLocalInspectionTool
if (methods.length == 1) {
final PsiCodeBlock body = methods[0].getBody();
if (body != null) {
final boolean [] recursive = new boolean[1];
final boolean [] bodyContainsForbiddenRefs = new boolean[1];
body.accept(new JavaRecursiveElementWalkingVisitor() {
@Override
public void visitMethodCallExpression(PsiMethodCallExpression methodCallExpression) {
super.visitMethodCallExpression(methodCallExpression);
if (methodCallExpression.resolveMethod() == methods[0]) {
recursive[0] = true;
bodyContainsForbiddenRefs[0] = true;
}
}
@Override
public void visitThisExpression(PsiThisExpression expression) {
bodyContainsForbiddenRefs[0] = true;
}
@Override
public void visitSuperExpression(PsiSuperExpression expression) {
bodyContainsForbiddenRefs[0] = true;
}
});
if (!recursive[0]) {
if (!bodyContainsForbiddenRefs[0]) {
holder.registerProblem(aClass.getBaseClassReference(), "Anonymous #ref #loc can be replaced with lambda",
ProblemHighlightType.LIKE_UNUSED_SYMBOL, new ReplaceWithLambdaFix());
ProblemHighlightType.GENERIC_ERROR_OR_WARNING, new ReplaceWithLambdaFix());
}
}
}

11
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/anonymous2lambda/beforeThisRefInside.java Normal file
View File

@@ -0,0 +1,11 @@
// "Replace with lambda" "false"
class Test {
{
Runnable x = new Runn<caret>able() {
public void run() {
this.toString();
}
};
}
}