Don't discover owners for dynamic EPs by default (it's not so useful any more)

GitOrigin-RevId: 244fe0318e8155dc73317bad48d38d0d3d33a5bf
This commit is contained in:
Dmitry Jemerov
2019-12-17 17:13:56 +00:00
committed by intellij-monorepo-bot
parent 77ce1c47a6
commit 8cfc6c5dae
2 changed files with 22 additions and 11 deletions
@@ -1838,4 +1838,6 @@ appcds.install.idleTooHeavyCPULoadDelay.description=Wait time for AppCDS startup
appcds.install.idleLongRetryDelay=900000
appcds.install.idleLongRetryDelay.description=Long wait time for AppCDS startup optimization works, e.g. used when computer is on battery
analyze.unloadable.discover.owners=false
# TODO please use EP com.intellij.registryKey for plugin/product specific keys
@@ -12,6 +12,7 @@ import com.intellij.openapi.fileEditor.OpenFileDescriptor
import com.intellij.openapi.progress.ProgressManager
import com.intellij.openapi.project.Project
import com.intellij.openapi.roots.ProjectRootManager
import com.intellij.openapi.util.registry.Registry
import com.intellij.openapi.vcs.ProjectLevelVcsManager
import com.intellij.openapi.vcs.annotate.FileAnnotation
import com.intellij.openapi.vcs.annotate.LineAnnotationAspect
@@ -122,19 +123,25 @@ class AnalyzeUnloadablePluginsAction : AnAction() {
appendln("EP usage statistics (${epUsagesMap.size} non-dynamic EPs remaining):")
val epUsagesList = epUsagesMap.toList().sortedByDescending { it.second }
for (pair in epUsagesList) {
appendln("${pair.second}: ${pair.first} (${extensionPointOwners.getOwner(pair.first)})")
}
appendln()
appendln("EPs grouped by owner:")
for (owner in extensionPointOwners.getSortedOwners()) {
val owned = extensionPointOwners.getOwnedEPs(owner)
appendln("$owner: ${owned.size}")
for (ep in owned) {
appendln(ep)
append("${pair.second}: ${pair.first}")
if (Registry.`is`("analyze.unloadable.discover.owners")) {
append(" (${extensionPointOwners.getOwner(pair.first)})")
}
appendln()
}
if (Registry.`is`("analyze.unloadable.discover.owners")) {
appendln()
appendln("EPs grouped by owner:")
for (owner in extensionPointOwners.getSortedOwners()) {
val owned = extensionPointOwners.getOwnedEPs(owner)
appendln("$owner: ${owned.size}")
for (ep in owned) {
appendln(ep)
}
appendln()
}
}
}
val fileName = String.format("AnalyzeUnloadablePlugins-Report-%s.txt", DateFormatUtil.formatDateTime(System.currentTimeMillis()))
@@ -172,7 +179,9 @@ class AnalyzeUnloadablePluginsAction : AnAction() {
analysisErrors.add("Cannot resolve EP ${extension.xmlElementName}")
continue
}
extensionPointOwners.discoverOwner(ep)
if (Registry.`is`("analyze.unloadable.discover.owners")) {
extensionPointOwners.discoverOwner(ep)
}
when (ep.dynamic.value) {
false -> nonDynamicEPs.add(ep.effectiveQualifiedName)