MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

don't use DumbAwareRunnable in 'invokeLater' calls - it doesn't make any difference

Browse Source
This commit is contained in:
Dmitry Batrak
2019-02-21 14:51:22 +03:00
parent 0509fd75c7
commit 8bbee943c2
8 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/idea-ui/src/com/intellij/jarRepository/RepositoryLibrarySynchronizer.java
+1 -2
View File
@@ -25,7 +25,6 @@ import com.intellij.openapi.application.WriteAction;
import com.intellij.openapi.module.Module;
import com.intellij.openapi.module.ModuleManager;
import com.intellij.openapi.project.DumbAware;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.roots.ModuleRootEvent;
import com.intellij.openapi.roots.ModuleRootListener;
@@ -156,7 +155,7 @@ public class RepositoryLibrarySynchronizer implements StartupActivity, DumbAware
return false;
});
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> {
ApplicationManager.getApplication().invokeLater(() -> {
for (Library library : toSync) {
if (LibraryTableImplUtil.isValidLibrary(library)) {
RepositoryUtils.reloadDependencies(project, (LibraryEx)library);
platform/editor-ui-ex/src/com/intellij/openapi/editor/ex/util/LexerEditorHighlighter.java
+1 -2
View File
@@ -22,7 +22,6 @@ import com.intellij.openapi.editor.markup.TextAttributes;
import com.intellij.openapi.fileTypes.PlainSyntaxHighlighter;
import com.intellij.openapi.fileTypes.SyntaxHighlighter;
import com.intellij.openapi.progress.ProcessCanceledException;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Comparing;
import com.intellij.openapi.util.text.StringUtil;
@@ -381,7 +380,7 @@ public class LexerEditorHighlighter implements EditorHighlighter, PrioritizedDoc
}
if(myEditor != null && !ApplicationManager.getApplication().isHeadlessEnvironment()) {
UIUtil.invokeLaterIfNeeded((DumbAwareRunnable)() -> myEditor.repaint(0, textLength));
UIUtil.invokeLaterIfNeeded(() -> myEditor.repaint(0, textLength));
}
}
platform/lang-impl/src/com/intellij/codeInsight/daemon/impl/PassExecutorService.java
+1 -2
View File
@@ -26,7 +26,6 @@ import com.intellij.openapi.fileTypes.FileType;
import com.intellij.openapi.progress.ProcessCanceledException;
import com.intellij.openapi.progress.ProgressIndicator;
import com.intellij.openapi.progress.ProgressManager;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.project.DumbService;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Key;
@@ -485,7 +484,7 @@ class PassExecutorService implements Disposable {
@NotNull final DaemonProgressIndicator updateProgress,
@NotNull final AtomicInteger threadsToStartCountdown,
@NotNull Runnable callbackOnApplied) {
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> {
ApplicationManager.getApplication().invokeLater(() -> {
if (isDisposed() || myProject.isDisposed() || !fileEditor.isValid()) {
updateProgress.cancel();
}
platform/lang-impl/src/com/intellij/codeInsight/highlighting/BraceHighlightingHandler.java
+1 -2
View File
@@ -31,7 +31,6 @@ import com.intellij.openapi.fileTypes.FileTypes;
import com.intellij.openapi.fileTypes.SyntaxHighlighter;
import com.intellij.openapi.fileTypes.SyntaxHighlighterFactory;
import com.intellij.openapi.progress.util.ProgressIndicatorUtils;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Conditions;
import com.intellij.openapi.util.Key;
@@ -109,7 +108,7 @@ public class BraceHighlightingHandler {
PsiFile injected = psiFile instanceof PsiBinaryFile || !isValidFile(psiFile)
? null
: getInjectedFileIfAny(editor, project, offset, psiFile, alarm);
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> {
ApplicationManager.getApplication().invokeLater(() -> {
try {
if (isValidEditor(editor) && isValidFile(injected)) {
EditorEx newEditor = (EditorEx)InjectedLanguageUtil.getInjectedEditorForInjectedFile(editor, injected);
platform/platform-api/src/com/intellij/util/ui/update/UiNotifyConnector.java
+1 -2
View File
@@ -19,7 +19,6 @@ import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.Application;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.application.ModalityState;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.util.Disposer;
import org.jetbrains.annotations.NotNull;
@@ -52,7 +51,7 @@ public class UiNotifyConnector implements Disposable, HierarchyListener{
if (isDisposed()) return;
if ((e.getChangeFlags() & HierarchyEvent.SHOWING_CHANGED) > 0) {
final Runnable runnable = (DumbAwareRunnable)() -> {
final Runnable runnable = () -> {
final Component c = myComponent.get();
if (isDisposed() || c == null) return;
platform/platform-impl/src/com/intellij/openapi/vcs/impl/FileStatusManagerImpl.java
+2 -2
View File
@@ -180,7 +180,7 @@ public class FileStatusManagerImpl extends FileStatusManager implements ProjectC
return;
}
if (!ApplicationManager.getApplication().isDispatchThread()) {
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> fileStatusesChanged(), ModalityState.any());
ApplicationManager.getApplication().invokeLater(() -> fileStatusesChanged(), ModalityState.any());
return;
}
@@ -212,7 +212,7 @@ public class FileStatusManagerImpl extends FileStatusManager implements ProjectC
public void fileStatusChanged(final VirtualFile file) {
final Application application = ApplicationManager.getApplication();
if (!application.isDispatchThread() && !application.isUnitTestMode()) {
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> fileStatusChanged(file));
ApplicationManager.getApplication().invokeLater(() -> fileStatusChanged(file));
return;
}
platform/platform-impl/src/com/intellij/openapi/wm/impl/welcomeScreen/WelcomeFrame.java
+1 -2
View File
@@ -13,7 +13,6 @@ import com.intellij.openapi.application.ApplicationNamesInfo;
import com.intellij.openapi.application.ModalityState;
import com.intellij.openapi.application.ex.ApplicationManagerEx;
import com.intellij.openapi.extensions.ExtensionPointName;
import com.intellij.openapi.project.DumbAwareRunnable;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.project.ProjectManager;
import com.intellij.openapi.project.ProjectManagerListener;
@@ -169,7 +168,7 @@ public class WelcomeFrame extends JFrame implements IdeFrame, AccessibleContextA
return;
}
ApplicationManager.getApplication().invokeLater((DumbAwareRunnable)() -> {
ApplicationManager.getApplication().invokeLater(() -> {
WindowManagerImpl windowManager = (WindowManagerImpl)WindowManager.getInstance();
windowManager.disposeRootFrame();
IdeFrameImpl[] frames = windowManager.getAllProjectFrames();
platform/vcs-impl/src/com/intellij/platform/PlatformVcsDetector.java
+1 -1
View File
@@ -26,7 +26,7 @@ public class PlatformVcsDetector implements ProjectComponent {
@Override
public void projectOpened() {
StartupManager.getInstance(myProject).runWhenProjectIsInitialized((DumbAwareRunnable)() -> {
final DumbAwareRunnable runnable = () -> {
final Runnable runnable = () -> {
VirtualFile file = ProjectBaseDirectory.getInstance(myProject).getBaseDir(myProject.getBaseDir());
if (myVcsManager.needAutodetectMappings()) {
AbstractVcs vcs = myVcsManager.findVersioningVcs(file);