MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Disabled "Cycle in components initialization" false positive when the component throws an exception during initialization

Browse Source
This commit is contained in:
Alexander Kirillin
2013-02-14 21:42:51 +04:00
parent 7a78af068a
commit 89f0da2f59
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/openapi/components/impl/ComponentManagerImpl.java
+15 -9
View File
@@ -578,17 +578,23 @@ public abstract class ComponentManagerImpl extends UserDataHolderBase implements
LOG.error(new Throwable("Cyclic component initialization: " + componentKey));
}
}
myInitializing = true;
myComponentsRegistry.registerComponentInstance(componentInstance);
initComponent(componentInstance);
long endTime = System.nanoTime();
long ms = (endTime - startTime) / 1000000;
if (ms > 10) {
if (logSlowComponents()) {
LOG.info(componentInstance.getClass().getName() + " initialized in " + ms + " ms");
try {
myInitializing = true;
myComponentsRegistry.registerComponentInstance(componentInstance);
initComponent(componentInstance);
long endTime = System.nanoTime();
long ms = (endTime - startTime) / 1000000;
if (ms > 10) {
if (logSlowComponents()) {
LOG.info(componentInstance.getClass().getName() + " initialized in " + ms + " ms");
}
}
}
myInitializing = false;
finally {
myInitializing = false;
}
myInitialized = true;
}
}