[devkit] DevKitUastInspectionBase cleanup CTOR usages

GitOrigin-RevId: 91176ac65fe7954653aaa35ff78eda9f675ffeb3
This commit is contained in:
Yann Cébron
2023-02-23 14:26:02 +00:00
committed by intellij-monorepo-bot
parent af43fc4a0e
commit 89cc796ca0
4 changed files with 8 additions and 4 deletions
@@ -9,6 +9,7 @@ import com.intellij.psi.PsiElementVisitor;
import com.intellij.util.ArrayUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.uast.UCallExpression;
import org.jetbrains.uast.UClass;
import org.jetbrains.uast.UElement;
import org.jetbrains.uast.UIdentifier;
@@ -17,6 +18,9 @@ public abstract class DevKitUastInspectionBase extends AbstractBaseUastLocalInsp
protected DevKitUastInspectionBase() {
}
/**
* When *NOT* overriding {@link #buildInternalVisitor} but using {@code checkClass|Method|Field}.
*/
@SafeVarargs
protected DevKitUastInspectionBase(Class<? extends UElement>... uElementsTypesHint) {
super(uElementsTypesHint);
@@ -1,4 +1,4 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.idea.devkit.inspections
import com.intellij.codeInspection.ProblemsHolder
@@ -17,7 +17,7 @@ import org.jetbrains.uast.UCallExpression
import org.jetbrains.uast.UExpression
import org.jetbrains.uast.visitor.AbstractUastNonRecursiveVisitor
class IncorrectParentDisposableInspection : DevKitUastInspectionBase(UCallExpression::class.java) {
class IncorrectParentDisposableInspection : DevKitUastInspectionBase() {
override fun isAllowed(holder: ProblemsHolder): Boolean = DevKitInspectionUtil.isAllowedInPluginsOnly(holder.file)
@@ -27,7 +27,7 @@ import org.jetbrains.uast.UastVisibility
import org.jetbrains.uast.getAnchorPsi
import org.jetbrains.uast.visitor.AbstractUastNonRecursiveVisitor
internal class NonFinalOrNonInternalExtensionClassInspection : DevKitUastInspectionBase(UClass::class.java) {
internal class NonFinalOrNonInternalExtensionClassInspection : DevKitUastInspectionBase() {
override fun buildInternalVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor = UastHintedVisitorAdapter.create(
holder.file.language, object : AbstractUastNonRecursiveVisitor() {
override fun visitClass(node: UClass): Boolean {
@@ -20,7 +20,7 @@ import org.jetbrains.uast.generate.UastCodeGenerationPlugin
import org.jetbrains.uast.generate.replace
import org.jetbrains.uast.visitor.AbstractUastNonRecursiveVisitor
internal class RetrievingLightServiceInspection : DevKitUastInspectionBase(UQualifiedReferenceExpression::class.java) {
internal class RetrievingLightServiceInspection : DevKitUastInspectionBase() {
private val COMPONENT_MANAGER_FQN = ComponentManager::class.java.canonicalName
private val COMPONENT_MANAGER_GET_SERVICE: CallMatcher = CallMatcher.anyOf(
CallMatcher.instanceCall(COMPONENT_MANAGER_FQN, "getService").parameterTypes(CommonClassNames.JAVA_LANG_CLASS),