IDEA-CR-63632 IDEA-243010 IJP-778 Reader mode: rename variable by review

GitOrigin-RevId: 6df42b9af3445c45d089d8cba16462e1fcb79b30
This commit is contained in:
Dmitry.Krasilschikov
2020-06-17 17:55:33 +03:00
committed by intellij-monorepo-bot
parent 74837c1753
commit 87fd308f5a
3 changed files with 10 additions and 11 deletions
@@ -19,12 +19,12 @@ class ReaderModeFileEditorListener : FileEditorManagerListener {
companion object {
private var EP_READER_MODE_PROVIDER = ExtensionPointName<ReaderModeProvider>("com.intellij.readerModeProvider")
fun applyReaderMode(project: Project, selectedEditor: FileEditor?, alreadyOpenedFilesOnly: Boolean = false) {
fun applyReaderMode(project: Project, selectedEditor: FileEditor?, fileIsOpenAlready: Boolean = false) {
if (selectedEditor is PsiAwareTextEditorImpl) {
val file = selectedEditor.file
if (matchMode(project, file)) {
EP_READER_MODE_PROVIDER.extensions().forEach {
it.applyModeChanged(project, selectedEditor.editor, instance(project).enabled, alreadyOpenedFilesOnly)
it.applyModeChanged(project, selectedEditor.editor, instance(project).enabled, fileIsOpenAlready)
}
}
}
@@ -8,5 +8,5 @@ import com.intellij.openapi.project.Project
* Use it to provide an activity that should be applied for editor in Read Mode
*/
interface ReaderModeProvider {
fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {}
fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {}
}
@@ -19,8 +19,7 @@ import com.intellij.xml.breadcrumbs.BreadcrumbsForceShownSettings
import com.intellij.xml.breadcrumbs.BreadcrumbsInitializingActivity
class BreadcrumbsReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean,
alreadyOpenedFilesOnly: Boolean) {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
val showBreadcrumbs = (readerMode && ReaderModeSettings.instance(project).showBreadcrumbs)
|| EditorSettingsExternalizable.getInstance().isBreadcrumbsShown
BreadcrumbsForceShownSettings.setForcedShown(showBreadcrumbs, editor)
@@ -29,8 +28,8 @@ class BreadcrumbsReaderModeProvider : ReaderModeProvider {
}
class HighlightingReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {
if (!alreadyOpenedFilesOnly) return
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
if (!fileIsOpenAlready) return
val highlighting =
if (readerMode && ReaderModeSettings.instance(project).hideWarnings) FileHighlightingSetting.SKIP_INSPECTION
@@ -53,7 +52,7 @@ class ReaderModeHighlightingSettingsProvider : DefaultHighlightingSettingProvide
}
class LigaturesReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
val scheme = editor.colorsScheme
val preferences = scheme.fontPreferences
scheme.fontPreferences =
@@ -67,7 +66,7 @@ class LigaturesReaderModeProvider : ReaderModeProvider {
class FontReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
if (readerMode) {
if (ReaderModeSettings.instance(project).increaseLineSpacing) {
setLineSpacing(editor, 1.4f)
@@ -86,13 +85,13 @@ class FontReaderModeProvider : ReaderModeProvider {
}
class DocsRenderingReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
DocRenderManager.setDocRenderingEnabled(editor, if (readerMode) ReaderModeSettings.instance(project).showRenderedDocs else null)
}
}
class InlaysReaderModeProvider : ReaderModeProvider {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, alreadyOpenedFilesOnly: Boolean) {
override fun applyModeChanged(project: Project, editor: Editor, readerMode: Boolean, fileIsOpenAlready: Boolean) {
InlayHintsPassFactory.setHintsEnabled(editor, readerMode && ReaderModeSettings.instance(project).showInlaysHints)
}
}