MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-highlighting] Report static fields that collide with record components

Browse Source 
Fixes IDEA-246454 bad code is green: record component already defined

GitOrigin-RevId: 1b2a48c0eb0b543ec9d60d7ed3cf2b3aabc3330c
This commit is contained in:
Tagir Valeev
2020-07-24 10:52:51 +00:00
committed by intellij-monorepo-bot
parent 4dfb7b9999
commit 874d090e21
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightUtil.java
+2
View File
@@ -651,6 +651,8 @@ public final class HighlightUtil {
PsiField fieldByName = aClass.findFieldByName(variable.getName(), false);
if (fieldByName != null && fieldByName != field) {
oldVariable = fieldByName;
} else {
oldVariable = ContainerUtil.find(aClass.getRecordComponents(), c -> c.getName().equals(field.getName()));
}
}
else {
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlightingRecords/RecordBasics.java
+3
View File
@@ -66,4 +66,7 @@ record ProhibitedMembers() {
System.out.println("initializer");
}</error>
<error descr="Modifier 'native' not allowed here">native</error> void test();
}
record StaticFieldCollides(int i) {
static int <error descr="Variable 'i' is already defined in the scope">i</error>;
}