MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

consistent descriptions

Browse Source
This commit is contained in:
Dmitry Batkovich
2013-04-26 10:12:56 +04:00
parent 1b4e29918d
commit 85c55c6fc3
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInspection/inheritance/SuperClassHasFrequentlyUsedInheritorsInspection.java
+9 -8
View File
@@ -4,7 +4,6 @@ import com.intellij.codeInsight.daemon.GroupNames;
import com.intellij.codeInspection.*;
import com.intellij.codeInspection.inheritance.search.InheritorsStatisticalDataSearch;
import com.intellij.codeInspection.inheritance.search.InheritorsStatisticsSearchResult;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
@@ -32,7 +31,7 @@ public class SuperClassHasFrequentlyUsedInheritorsInspection extends BaseJavaLoc
@NotNull
@Override
public String getDisplayName() {
return "Direct inheritance on super class not frequently used";
return "Class may extend a commonly used base class instead of implementing interface or extending abstract class";
}
@Override
@@ -45,9 +44,12 @@ public class SuperClassHasFrequentlyUsedInheritorsInspection extends BaseJavaLoc
public ProblemDescriptor[] checkClass(@NotNull final PsiClass aClass,
@NotNull final InspectionManager manager,
final boolean isOnTheFly) {
if (aClass.isInterface() || aClass instanceof PsiTypeParameter || aClass.getMethods().length != 0) return null;
if (aClass.isInterface() || aClass.hasModifierProperty(PsiModifier.ABSTRACT)) return null;
if (aClass.isInterface() ||
aClass instanceof PsiTypeParameter ||
aClass.getMethods().length != 0 ||
aClass.hasModifierProperty(PsiModifier.ABSTRACT)) {
return null;
}
final PsiClass superClass = getSuperIfUnique(aClass);
if (superClass == null) return null;
@@ -63,8 +65,7 @@ public class SuperClassHasFrequentlyUsedInheritorsInspection extends BaseJavaLoc
boolean isFirst = true;
for (final InheritorsStatisticsSearchResult searchResult : topInheritors) {
LocalQuickFix quickFix =
new ChangeSuperClassFix(searchResult.getPsiClass(), searchResult.getPercent(), superClass);
LocalQuickFix quickFix = new ChangeSuperClassFix(searchResult.getPsiClass(), searchResult.getPercent(), superClass);
if (isFirst) {
quickFix = ChangeSuperClassFix.highPriority(quickFix);
isFirst = false;
@@ -75,7 +76,7 @@ public class SuperClassHasFrequentlyUsedInheritorsInspection extends BaseJavaLoc
}
}
return new ProblemDescriptor[]{manager
.createProblemDescriptor(aClass, String.format("Most of inheritors of this %s are not direct", superClass.getQualifiedName()), false,
.createProblemDescriptor(aClass, "Class may extend a commonly used base class instead of implementing interface or extending abstract class", false,
topInheritorsQuickFix.toArray(new LocalQuickFix[topInheritorsQuickFix.size()]),
ProblemHighlightType.INFORMATION)};
}
resources-en/src/inspectionDescriptions/SuperClassHasFrequentlyUsedInheritors.html
+2 -1
View File
@@ -15,6 +15,7 @@
-->
<html>
<body>
This inspection find super classes that can be replaced by another frequently used super
This inspection finds commonly used base class that could be extended instead of implementing interface or extending abstract class.
For example: <code>java.util.List</code> could be implemented by inheriting from <code>java.util.AbstractList</code>.
</body>
</html>