MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 06:50:54 +07:00
Code Issues Packages Projects Releases Wiki Activity

[settings-sync] IDEA-335945 Close the GotIt popup if Settings Sync node is hidden by scrolling

Browse Source 
The change is needed locally, but I think it is an expected behavior for all GotIt tooltips.

GitOrigin-RevId: 308845fd00bc2445fd85544ebf2423e299cce264
This commit is contained in:
Konstantin Hudyakov
2023-10-26 19:25:44 +03:00
committed by intellij-monorepo-bot
parent e289bf0253
commit 8583289898
1 changed files with 25 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
platform/platform-impl/src/com/intellij/ui/GotItTooltip.kt
View File

@@ -20,10 +20,12 @@ import com.intellij.openapi.util.Disposer
import com.intellij.openapi.util.Key
import com.intellij.ui.awt.RelativePoint
import com.intellij.util.Alarm
import com.intellij.util.ui.JBInsets
import com.intellij.util.ui.PositionTracker
import org.jetbrains.annotations.Nls
import org.jetbrains.annotations.NonNls
import java.awt.Component
import java.awt.Insets
import java.awt.Point
import java.awt.event.ComponentAdapter
import java.awt.event.ComponentEvent
@@ -373,16 +375,32 @@ class GotItTooltip internal constructor(@NonNls val id: String,
fun createAndShow(component: JComponent, pointProvider: (Component, Balloon) -> Point): Balloon {
val tracker = object : PositionTracker<Balloon>(component) {
override fun recalculateLocation(balloon: Balloon): RelativePoint? =
if (getComponent().isShowing)
RelativePoint(component, pointProvider(component, balloon))
override fun recalculateLocation(balloon: Balloon): RelativePoint? {
if (!component.isShowing) {
hideBalloon(balloon)
return null
}
val point = pointProvider(component, balloon)
@Suppress("UseDPIAwareInsets")
// need to include the corners, because Rectangle#contains() check that point is really inside the rectangle
val visibleRect = (component as? JComponent)?.visibleRect?.also { JBInsets.addTo(it, Insets(1, 1, 1, 1)) }
// hide the balloon if the target point is not inside the visible rect (except the heavyweight components)
return if (visibleRect == null || visibleRect.contains(point)) {
RelativePoint(component, point)
}
else {
SwingUtilities.invokeLater {
balloon.hide(true)
GotItUsageCollector.instance.logClose(id, GotItUsageCollectorGroup.CloseType.AncestorRemoved)
}
hideBalloon(balloon)
null
}
}
private fun hideBalloon(balloon: Balloon) {
SwingUtilities.invokeLater {
balloon.hide(true)
GotItUsageCollector.instance.logClose(id, GotItUsageCollectorGroup.CloseType.AncestorRemoved)
}
}
}
val balloon = createBalloon().also {
val dispatcherDisposable = Disposer.newDisposable()