MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 13:02:30 +07:00
Code Issues Packages Projects Releases Wiki Activity

method refs: is exact should check super methods for this/super qualifiers only (IDEA-124507)

Browse Source
This commit is contained in:
Anna Kozlova
2014-04-28 12:57:27 +02:00
parent 9929113aed
commit 84deec968d
3 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/java-psi-impl/src/com/intellij/psi/impl/source/tree/java/PsiMethodReferenceExpressionImpl.java
View File

@@ -136,7 +136,8 @@ public class PsiMethodReferenceExpressionImpl extends PsiReferenceExpressionBase
if (containingClass != null) {
PsiMethod[] methods = null;
if (element instanceof PsiIdentifier) {
methods = containingClass.findMethodsByName(element.getText(), !qualifierResolveResult.isReferenceTypeQualified());
final PsiExpression qualifierExpression = getQualifierExpression();
methods = containingClass.findMethodsByName(element.getText(), qualifierExpression instanceof PsiThisExpression || qualifierExpression instanceof PsiSuperExpression);
}
else if (isConstructor()) {
final PsiElementFactory factory = JavaPsiFacade.getElementFactory(getProject());

21
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/mostSpecific/SuperMethodsInExactCheck.java Normal file
View File

@@ -0,0 +1,21 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
import java.util.concurrent.Callable;
class Test {
private static void <warning descr="Private method 'foo(java.lang.Runnable)' is never used">foo</warning>(Runnable runnable) {
System.out.println(runnable);
}
private static void foo(Callable<Iterator<?>> callable) {
System.out.println(callable);
}
public static void main(String[] args) {
final Collection<Void> collection = new ArrayList<>();
final Iterable<Void> iterable = collection;
foo(iterable::iterator);
foo(collection::iterator);
}
}

4
java/java-tests/testSrc/com/intellij/codeInsight/daemon/lambda/MostSpecificResolutionTest.java
View File

@@ -95,6 +95,10 @@ public class MostSpecificResolutionTest extends LightDaemonAnalyzerTestCase {
doTest();
}
public void testSuperMethodsInExactCheck() throws Exception {
doTest();
}
private void doTest() {
doTest(true);
}