JBAI-14736: Remove QuickfixRankingModelLoading and disable ML ranking for import quick fixes

- Set the default for `quickfix.ranking.ml` registry key to DISABLED.
- Removed `QuickfixRankingModelLoading` activity for model loading.


(cherry picked from commit 6b2983e319a62a7528e2f37614ab3c504b9b8c86)

IJ-CR-165459

GitOrigin-RevId: 7c8be37d89952300aa8275ccb4d2bcfd858b00e6
This commit is contained in:
Nikita Ermolenko
2025-06-11 16:19:08 +03:00
committed by intellij-monorepo-bot
parent 947922ff3a
commit 842c5a9808
2 changed files with 1 additions and 17 deletions

View File

@@ -3,9 +3,8 @@
<statistics.counterUsagesCollector implementationClass="com.intellij.python.ml.features.imports.PyCharmImportsRankingLogs"/>
<registryKey
key="quickfix.ranking.ml"
defaultValue="[IN_EXPERIMENT*|ENABLED|DISABLED]"
defaultValue="[DISABLED*]"
description="Enable ML ranking in quick fix for missing imports"/>
<postStartupActivity implementation="com.intellij.python.ml.features.imports.QuickfixRankingModelLoading"/>
<applicationService serviceInterface="com.jetbrains.python.codeInsight.imports.ImportChooser"
serviceImplementation="com.intellij.python.ml.features.imports.PyMLImportChooser" overrides="true"/>
</extensions>

View File

@@ -2,9 +2,6 @@
package com.intellij.python.ml.features.imports
import com.intellij.openapi.components.Service
import com.intellij.openapi.components.service
import com.intellij.openapi.project.Project
import com.intellij.openapi.startup.ProjectActivity
import com.jetbrains.ml.api.feature.Feature
import com.jetbrains.ml.api.feature.FeatureDeclaration
import com.jetbrains.ml.api.feature.FeatureFilter
@@ -13,7 +10,6 @@ import com.jetbrains.ml.api.model.MLModel
import com.jetbrains.ml.api.model.MLModelLoader
import com.jetbrains.ml.models.PythonImportsRankingModelHolder
import com.jetbrains.ml.tools.model.MLModelLoaders
import com.intellij.openapi.diagnostic.thisLogger
import com.jetbrains.ml.tools.model.ModelDistributionReaders
import com.jetbrains.ml.tools.model.catboost.CatBoostDistributionFormat
import com.jetbrains.ml.tools.model.suspendable.MLModelSuspendableService
@@ -29,17 +25,6 @@ class ImportsRankingModelService : MLModelSuspendableService<MLModel<Double>, Do
))
)
private class QuickfixRankingModelLoading : ProjectActivity {
override suspend fun execute(project: Project) {
if (!service<FinalImportRankingStatusService>().shouldLoadModel) return
try {
service<ImportsRankingModelService>().loadModel()
} catch (e: RuntimeException) {
thisLogger().error("Failed to load python imports ranking model", e)
}
}
}
private class MissingTypingFeaturesLoader(private val baseLoader: MLModelLoader<MLModel<Double>, Double>) : MLModelLoader<MLModel<Double>, Double> {
override fun loadModel(executor: ExecutorService, parameters: Map<String, Any>?): CompletableFuture<MLModel<Double>> {