MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-18816 Test that glued and long string literals are not saved in stubs

Browse Source
This commit is contained in:
Mikhail Golubev
2017-07-19 19:28:31 +03:00
parent f20ab38e84
commit 840769d43f
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/psi/impl/stubs/PyTypingAliasStubType.java
+2 -2
View File
@@ -39,7 +39,7 @@ import static com.jetbrains.python.psi.PyUtil.as;
* @author Mikhail Golubev
*/
public class PyTypingAliasStubType extends CustomTargetExpressionStubType<PyTypingAliasStub> {
private static final int STRING_LITERAL_LENGTH_THRESHOLD = 120;
private static final int STRING_LITERAL_LENGTH_THRESHOLD = 100;
private static final Pattern TYPE_ANNOTATION_LIKE = Pattern.compile("\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*" +
"(\\.\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)*" +
@@ -96,7 +96,7 @@ public class PyTypingAliasStubType extends CustomTargetExpressionStubType<PyTypi
final PyStringLiteralExpression pyString = as(expression, PyStringLiteralExpression.class);
if (pyString != null) {
if (pyString.getStringNodes().size() != 1 && pyString.getTextLength() > STRING_LITERAL_LENGTH_THRESHOLD) {
if (pyString.getStringNodes().size() != 1 || pyString.getTextLength() > STRING_LITERAL_LENGTH_THRESHOLD) {
return false;
}
final String content = pyString.getStringValue();
python/testData/stubs/TypeAliasStubs.py
+3
View File
@@ -5,6 +5,9 @@ __version__ = '0.1'
S1_ok = "foo"
S2_ok = "foo.bar"
S3_ok = "foo.bar[baz]"
too_long_string = "foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo.foo"
natural_text = "Foo is baz."
glued_string = 'foo' '.bar'
# Such expressions are kept as qualified expressions in PyTargetExpressionStub
# with initializer type of ReferenceExpression instead of custom stubs for