MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-21 22:11:40 +07:00
Code Issues Packages Projects Releases Wiki Activity

java completion: don't suggest public classes with inaccessible containers

Browse Source 
GitOrigin-RevId: 08e09eb6e4e96b31ccc613a741c756608449ec6e
This commit is contained in:
peter
2019-06-17 17:32:14 +02:00
committed by intellij-monorepo-bot
parent c037490b9a
commit 837c4f206f
3 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionUtil.java
View File

@@ -876,7 +876,7 @@ public class JavaCompletionUtil {
}
public static boolean isSourceLevelAccessible(PsiElement context, PsiClass psiClass, final boolean pkgContext) {
if (!JavaPsiFacade.getInstance(psiClass.getProject()).getResolveHelper().isAccessible(psiClass, context, null)) {
if (!JavaPsiFacade.getInstance(psiClass.getProject()).getResolveHelper().isAccessible(psiClass, context, psiClass.getContainingClass())) {
return false;
}

3
java/java-tests/testData/codeInsight/completion/className/NoInnerInaccessibleClass.java Normal file
View File

@@ -0,0 +1,3 @@
class C {
InnerInter<caret>
}

5
java/java-tests/testSrc/com/intellij/java/codeInsight/completion/ClassNameCompletionTest.java
View File

@@ -296,6 +296,11 @@ public class ClassNameCompletionTest extends LightFixtureCompletionTestCase {
doJavaTest('\n');
}
public void testNoInnerInaccessibleClass() {
myFixture.addClass("package foo; interface Intf { interface InnerInterface {} }");
doAntiTest();
}
private void doJavaTest(char toType) {
final String path = "/nameCompletion/java";
myFixture.configureByFile(path + "/" + getTestName(false) + "-source.java");