create from new: fix type parameters setup (IDEA-128679; IDEA-128682)

java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateFromUsageBaseFix.java

@@ -475,7 +475,7 @@ public abstract class CreateFromUsageBaseFix extends BaseIntentionAction {
       } else {
         while (true) {
           final String paramName = idx > 0 ? "T" + idx : "T";
-          if (!typeParamNames.contains(paramName)) {
+          if (typeParamNames.add(paramName)) {
             targetClass.getTypeParameterList().add(factory.createTypeParameterFromText(paramName, null));
             break;
           }

java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateInnerClassFromNewFix.java

@@ -67,9 +67,8 @@ public class CreateInnerClassFromNewFix extends CreateClassFromNewFix {
     }
     created = (PsiClass)targetClass.add(created);
 
-    setupClassFromNewExpression(created, newExpression);
-
     setupGenericParameters(created, ref);
+    setupClassFromNewExpression(created, newExpression);
   }
 
   private static boolean isInThisOrSuperCall(PsiNewExpression newExpression) {

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createInnerClassFromNew/afterTypeParamSetup.java

@@ -0,0 +1,11 @@
+// "Create Inner Class 'AInner'" "true"
+class Test {
+  {
+    AInner aInner = new AInner<String>(42);
+  }
+
+    private class AInner<T> {
+        public AInner(int i) {
+        }
+    }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createInnerClassFromNew/afterTypeParamSetup1.java

@@ -0,0 +1,11 @@
+// "Create Inner Class 'AInner'" "true"
+class Test {
+  {
+    AInner aInner = new AInner<String, String>(42);
+  }
+
+    private class AInner<T, T1> {
+        public AInner(int i) {
+        }
+    }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createInnerClassFromNew/beforeTypeParamSetup.java

@@ -0,0 +1,6 @@
+// "Create Inner Class 'AInner'" "true"
+class Test {
+  {
+    AInner aInner = new AIn<caret>ner<String>(42);
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createInnerClassFromNew/beforeTypeParamSetup1.java

@@ -0,0 +1,6 @@
+// "Create Inner Class 'AInner'" "true"
+class Test {
+  {
+    AInner aInner = new AIn<caret>ner<String, String>(42);
+  }
+}