MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

report DataContext.getData when capturing UI snapshot

Browse Source 
GitOrigin-RevId: 7188990ecb2003a8e888a9323326934d9cf6c175
This commit is contained in:
Gregory.Shrago
2024-07-11 11:32:56 +00:00
committed by intellij-monorepo-bot
parent 5778a45943
commit 808bfe5e81
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/openapi/actionSystem/impl/PreCachedDataContext.java
+13
View File
@@ -62,6 +62,7 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
private static final Map<String, Integer> ourDataKeysIndices = new ConcurrentHashMap<>();
private static final AtomicInteger ourDataKeysCount = new AtomicInteger();
private static final Interner<String> ourEDTWarnsInterner = Interner.createStringInterner();
private static boolean ourIsCapturingSnapshot;
private final ComponentRef myComponentRef;
private final AtomicReference<KeyFMap> myUserData;
@@ -69,6 +70,7 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
private final DataManagerImpl myDataManager;
private final int myDataKeysCount;
/** @noinspection AssignmentToStaticFieldFromInstanceMethod*/
PreCachedDataContext(@Nullable Component component) {
myComponentRef = new ComponentRef(component);
myUserData = new AtomicReference<>(KeyFMap.EMPTY_MAP);
@@ -106,6 +108,7 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
int keyCount;
FList<ProviderData> cachedData;
MySink sink = new MySink();
ourIsCapturingSnapshot = true;
try (AccessToken ignore = SlowOperations.startSection(SlowOperations.FORCE_ASSERT)) {
while (true) {
sink.keys = null;
@@ -116,6 +119,9 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
if (keyCount == DataKey.allKeysCount()) break;
}
}
finally {
ourIsCapturingSnapshot = false;
}
myDataKeysCount = keyCount;
myCachedData = cachedData;
ourInstances.add(this);
@@ -183,6 +189,9 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
if (myCachedData.isEmpty()) return null;
boolean isEDT = EDT.isCurrentThreadEdt();
if (isEDT && ourIsCapturingSnapshot) {
reportGetDataInsideCapturingSnapshot();
}
boolean noRulesSection = isEDT && ActionUpdater.Companion.isNoRulesInEDTSection();
boolean rulesSuppressed = isEDT && LoadingState.COMPONENTS_LOADED.isOccurred() && Registry.is("actionSystem.update.actions.suppress.dataRules.on.edt");
boolean rulesAllowed = !CommonDataKeys.PROJECT.is(dataId) && !rulesSuppressed && !noRulesSection;
@@ -262,6 +271,10 @@ class PreCachedDataContext implements AsyncDataContext, UserDataHolder, AnAction
return answer;
}
private static void reportGetDataInsideCapturingSnapshot() {
LOG.error("DataContext must not be queried during another DataContext creation");
}
private static void reportValueProvidedByRulesUsage(@NotNull String dataId, boolean error) {
if (!Registry.is("actionSystem.update.actions.warn.dataRules.on.edt")) return;
if (EDT.isCurrentThreadEdt() && SlowOperations.isInSection(SlowOperations.ACTION_UPDATE) &&