PY-13264 Consider qualifier of reference expression when collecting names used in function

python/src/com/jetbrains/python/refactoring/PyRefactoringUtil.java

@@ -158,6 +158,7 @@ public class PyRefactoringUtil {
       @Override
       public void visitPyReferenceExpression(PyReferenceExpression node) {
         variables.add(node.getReferencedName());
+        super.visitPyReferenceExpression(node);
       }
 
       @Override

python/testData/refactoring/introduceVariable/dontSuggestNameOfCalledFunction.py

@@ -0,0 +1,5 @@
+def select():
+    return 'spam'
+
+def func():
+    return se<caret>lect().upper()

python/testSrc/com/jetbrains/python/refactoring/PyIntroduceTestCase.java

@@ -42,9 +42,9 @@ public abstract class PyIntroduceTestCase extends PyTestCase {
 
   protected Collection<String> buildSuggestions(Class<? extends PyExpression> parentClass) {
     myFixture.configureByFile(getTestName(true) + ".py");
-    IntroduceHandler handler = createHandler();
-    PyExpression expr = PsiTreeUtil.getParentOfType(myFixture.getFile().findElementAt(myFixture.getEditor().getCaretModel().getOffset()),
-                                                    parentClass);
+    final IntroduceHandler handler = createHandler();
+    final PyExpression expr = PsiTreeUtil.getParentOfType(myFixture.getFile().findElementAt(myFixture.getCaretOffset()), parentClass);
+    assertNotNull(expr);
     return handler.getSuggestedNames(expr);
   }
 

python/testSrc/com/jetbrains/python/refactoring/PyIntroduceVariableTest.java

@@ -78,6 +78,12 @@ public class PyIntroduceVariableTest extends PyIntroduceTestCase {
     assertFalse(strings.contains("dict"));
   }
 
+  // PY-13264
+  public void testDontSuggestNameOfCalledFunction() {
+    final Collection<String> suggestions = buildSuggestions(PyCallExpression.class);
+    assertDoesntContain(suggestions, "select");
+  }
+
   public void testSuggestNamesNotInScope() {  // PY-4605
     final Collection<String> strings = buildSuggestions(PyExpression.class);
     assertTrue(strings.contains("myfunc1"));