MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-21161 Check that index inside .format() chunk doesn't contain quotes it will be wrapped into

Browse Source
This commit is contained in:
Mikhail Golubev
2016-10-25 21:30:13 +03:00
parent a88719627f
commit 7f476d1302
4 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/codeInsight/intentions/PyConvertToFStringIntention.java
+1 -1
View File
@@ -366,7 +366,7 @@ public class PyConvertToFStringIntention extends PyBaseIntentionAction {
continue;
}
final char quote = invertQuote(hostStringQuote);
if (indexText.indexOf('\'') >= 0 && indexText.indexOf(quote) >= 0) {
if (indexText.indexOf(hostStringQuote) >= 0 || indexText.indexOf(quote) >= 0) {
return null;
}
escaped.add("[" + quote + indexText + quote + "]");
python/testData/intentions/PyConvertToFStringIntentionTest/formatMethodIndexContainsHostAlternativeQuote.py
+1
View File
@@ -0,0 +1 @@
'{foo["]}'.format(foo=undefined)
python/testData/intentions/PyConvertToFStringIntentionTest/formatMethodIndexContainsHostAlternativeQuote_after.py
+1
View File
@@ -0,0 +1 @@
'{foo["]}'.format(foo=undefined)
python/testSrc/com/jetbrains/python/intentions/PyConvertToFStringIntentionTest.java
+4
View File
@@ -96,6 +96,10 @@ public class PyConvertToFStringIntentionTest extends PyIntentionTestCase {
doTest();
}
public void testFormatMethodIndexContainsHostAlternativeQuote() {
doTest();
}
public void testPercentOperatorWidthAndPrecision() {
doTest();
}