PY-25720 Fixed NPE when associating created virtualenv without any project open

This commit is contained in:
Andrey Vlasovskikh
2017-08-21 21:30:46 +03:00
parent 46c9090035
commit 7ea46d3c36
4 changed files with 5 additions and 5 deletions
@@ -59,7 +59,7 @@ import java.util.List;
import java.util.Set;
public class PyActiveSdkConfigurable implements UnnamedConfigurable {
private final Project myProject;
@NotNull private final Project myProject;
@Nullable private final Module myModule;
private MySdkModelListener mySdkModelListener = new MySdkModelListener();
private PyConfigurableInterpreterList myInterpreterList;
@@ -350,7 +350,7 @@ public class PythonSdkDetailsDialog extends DialogWrapper {
additionalData = new PythonSdkAdditionalData(PythonSdkFlavor.getFlavor(modificator.getHomePath()));
modificator.setSdkAdditionalData(additionalData);
}
if (isAssociated) {
if (isAssociated && myProject != null) {
additionalData.associateWithProject(myProject);
}
else {
@@ -105,7 +105,7 @@ public class PythonSdkAdditionalData implements SdkAdditionalData {
myAssociateWithNewProject = false;
}
public void associateWithProject(Project project) {
public void associateWithProject(@NotNull Project project) {
final String path = project.getBasePath();
if (path != null) {
myAssociatedProjectPath = FileUtil.toSystemIndependentName(path);
@@ -117,7 +117,7 @@ public class PythonSdkAdditionalData implements SdkAdditionalData {
myAssociateWithNewProject = true;
}
public void reassociateWithCreatedProject(Project project) {
public void reassociateWithCreatedProject(@NotNull Project project) {
if (myAssociateWithNewProject) {
associateWithProject(project);
}
@@ -192,7 +192,7 @@ public class PythonSdkDetailsStep extends BaseListPopupStep<String> {
if (myNewProject) {
((PythonSdkAdditionalData)additionalData).associateWithNewProject();
}
else {
else if (myProject != null) {
((PythonSdkAdditionalData)additionalData).associateWithProject(myProject);
}
}