MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: add assertions instead of silently ignoring problems

Browse Source
This commit is contained in:
Bas Leijdekkers
2016-09-13 13:03:09 +02:00
parent 30dccf6ead
commit 7e8935ecc3
2 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/BaseInspection.java
+4 -3
View File
@@ -118,9 +118,10 @@ public abstract class BaseInspection extends BaseJavaBatchLocalInspectionTool {
@Override
@NotNull
public final PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder,
boolean isOnTheFly) {
if (!shouldInspect(holder.getFile())) {
public final PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
final PsiFile file = holder.getFile();
assert file.isPhysical();
if (!shouldInspect(file)) {
return new PsiElementVisitor() { };
}
final BaseInspectionVisitor visitor = buildVisitor();
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/BaseInspectionVisitor.java
+3 -10
View File
@@ -96,10 +96,7 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
else {
nameIdentifier = aClass.getNameIdentifier();
}
if (nameIdentifier != null && !nameIdentifier.isPhysical()) {
nameIdentifier = nameIdentifier.getNavigationElement();
}
if (nameIdentifier == null || !nameIdentifier.isPhysical()) {
if (nameIdentifier == null) {
registerError(aClass.getContainingFile(), infos);
}
else {
@@ -182,9 +179,7 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
protected final void registerError(@NotNull PsiElement location,
final ProblemHighlightType highlightType,
Object... infos) {
if (!location.isPhysical() || location.getTextLength() == 0 && !(location instanceof PsiFile)) {
return;
}
assert location.getTextLength() != 0 || location instanceof PsiFile;
final LocalQuickFix[] fixes = createAndInitFixes(infos);
final String description = inspection.buildErrorString(infos);
holder.registerProblem(location, description, highlightType, fixes);
@@ -197,9 +192,7 @@ public abstract class BaseInspectionVisitor extends JavaElementVisitor {
protected final void registerErrorAtOffset(@NotNull PsiElement location, int offset, int length,
ProblemHighlightType highlightType,
Object... infos) {
if (location.getTextLength() == 0 || length == 0) {
return;
}
assert !(location.getTextLength() == 0 || length == 0);
final LocalQuickFix[] fixes = createAndInitFixes(infos);
final String description = inspection.buildErrorString(infos);
final TextRange range = new TextRange(offset, offset + length);