MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

DataFlowInstructionVisitor: allow reporting variable assigned to the same value for Strings

Browse Source
This commit is contained in:
Tagir Valeev
2019-02-20 16:36:40 +07:00
parent dafe2e8918
commit 7de1dff527
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/DataFlowInstructionVisitor.java
+4 -3
View File
@@ -53,9 +53,7 @@ final class DataFlowInstructionVisitor extends StandardInstructionVisitor {
@Override
public DfaInstructionState[] visitAssign(AssignInstruction instruction, DataFlowRunner runner, DfaMemoryState memState) {
PsiExpression left = instruction.getLExpression();
if (left != null && !Boolean.FALSE.equals(mySameValueAssigned.get(left)) && !TypeUtils.isJavaLangString(left.getType())) {
// Reporting strings is skipped because string reassignment might be intentionally used to deduplicate the heap objects
// (we compare strings by contents)
if (left != null && !Boolean.FALSE.equals(mySameValueAssigned.get(left))) {
if (!left.isPhysical()) {
if (LOG.isDebugEnabled()) {
LOG.debug("Non-physical element in assignment instruction: " + left.getParent().getText(), new Throwable());
@@ -65,6 +63,9 @@ final class DataFlowInstructionVisitor extends StandardInstructionVisitor {
DfaValue target = memState.getStackValue(1);
if (target != null && memState.areEqual(value, target) &&
!(value instanceof DfaConstValue && isFloatingZero(((DfaConstValue)value).getValue())) &&
// Reporting strings is skipped because string reassignment might be intentionally used to deduplicate the heap objects
// (we compare strings by contents)
!(TypeUtils.isJavaLangString(left.getType()) && !memState.isNull(value)) &&
!isAssignmentToDefaultValueInConstructor(instruction, runner, target)) {
mySameValueAssigned.merge(left, Boolean.TRUE, Boolean::logicalAnd);
}