MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-06 03:21:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

Do not provide HTML documentation for word suggestions in HTML text

Browse Source 
GitOrigin-RevId: a372d66578dbbc2a61ce42e86174e1114b9a8652
This commit is contained in:
Piotr Tomiak
2021-09-08 14:06:03 +02:00
committed by intellij-monorepo-bot
parent 40277c2d34
commit 7da253903e
2 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
xml/impl/src/com/intellij/xml/util/documentation/HtmlDocumentationProvider.java
View File

@@ -196,6 +196,12 @@ public class HtmlDocumentationProvider implements DocumentationProvider {
}
private PsiMetaData findDescriptor(PsiManager psiManager, String text, PsiElement context) {
if (context != null
&& (context.getNode() == null
|| context.getNode().getElementType() == XmlTokenType.XML_END_TAG_START
|| context.getParent() instanceof XmlText)) {
return null;
}
String key = StringUtil.toLowerCase(text);
final HtmlTagDescriptor descriptor = HtmlDescriptorsTable.getTagDescriptor(key);

18
xml/tests/src/com/intellij/html/HtmlDocumentationTest.java
View File

@@ -18,13 +18,13 @@ package com.intellij.html;
import com.intellij.codeInsight.documentation.DocumentationManager;
import com.intellij.lang.documentation.DocumentationProvider;
import com.intellij.psi.PsiElement;
import com.intellij.testFramework.LightPlatformCodeInsightTestCase;
import com.intellij.testFramework.fixtures.BasePlatformTestCase;
import junit.framework.ComparisonFailure;
import java.util.Collections;
import java.util.List;
public class HtmlDocumentationTest extends LightPlatformCodeInsightTestCase {
public class HtmlDocumentationTest extends BasePlatformTestCase {
public void testQuickDocumentationHtml5Tag() {
doTest("<!DOCTYPE html>\n" +
"<html>\n" +
@@ -156,10 +156,18 @@ public class HtmlDocumentationTest extends LightPlatformCodeInsightTestCase {
Collections.singletonList("https://developer.mozilla.org/en-us/docs/web/api/htmlmediaelement/stalled_event"));
}
public void testLookupDocWordCompletions() {
myFixture.configureByText("test.html", "<html lang='en'>la<caret>n");
PsiElement originalElement = myFixture.getFile().findElementAt(myFixture.getEditor().getCaretModel().getOffset());
DocumentationProvider documentationProvider = DocumentationManager.getProviderFromElement(originalElement);
PsiElement element = documentationProvider.getDocumentationElementForLookupItem(originalElement.getManager(), "lang", originalElement);
assertNull(element);
}
private void doTest(String text, String doc, List<String> url) {
configureFromFileText("test.html", text);
PsiElement originalElement = getFile().findElementAt(getEditor().getCaretModel().getOffset());
PsiElement element = DocumentationManager.getInstance(getProject()).findTargetElement(getEditor(), getFile());
myFixture.configureByText("test.html", text);
PsiElement originalElement = myFixture.getFile().findElementAt(myFixture.getEditor().getCaretModel().getOffset());
PsiElement element = DocumentationManager.getInstance(getProject()).findTargetElement(myFixture.getEditor(), myFixture.getFile());
DocumentationProvider documentationProvider = DocumentationManager.getProviderFromElement(originalElement);
String generatedDoc = documentationProvider.generateDoc(element, originalElement);