MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

lambda return value: do not check containing method name against lambda return value

Browse Source
This commit is contained in:
Anna Kozlova
2014-11-18 18:36:30 +01:00
parent a86746b8d0
commit 7ccff9a7e8
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspectionBase.java
+3 -3
View File
@@ -156,10 +156,10 @@ public class SuspiciousNameCombinationInspectionBase extends BaseJavaBatchLocalI
@Override
public void visitReturnStatement(final PsiReturnStatement statement) {
final PsiExpression returnValue = statement.getReturnValue();
PsiMethod containingMethod = PsiTreeUtil.getParentOfType(returnValue, PsiMethod.class);
if (returnValue instanceof PsiReferenceExpression && containingMethod != null) {
PsiElement containingMethod = PsiTreeUtil.getParentOfType(returnValue, PsiMethod.class, PsiLambdaExpression.class);
if (returnValue instanceof PsiReferenceExpression && containingMethod instanceof PsiMethod) {
final String refName = ((PsiReferenceExpression)returnValue).getReferenceName();
checkCombination(returnValue, containingMethod.getName(), refName, "suspicious.name.return");
checkCombination(returnValue, ((PsiMethod)containingMethod).getName(), refName, "suspicious.name.return");
}
}
java/java-tests/testData/inspection/suspiciousNameCombination/returnValue/src/ReturnValue.java
+12
View File
@@ -3,4 +3,16 @@ public class ReturnValue {
int y=0;
return y;
}
interface I {
int m();
}
public int getY() {
I i = () -> {
int x = 0;
return x;
}
return i.m();
}
}