MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: ignore more parentheses

Browse Source
This commit is contained in:
Bas Leijdekkers
2016-02-10 21:06:04 +01:00
parent 475d294868
commit 7b845b5a86
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/logging/LogStatementGuardedByLogConditionInspectionBase.java
+3 -7
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2000-2013 JetBrains s.r.o.
* Copyright 2000-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@ import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.ParenthesesUtils;
import com.siyeh.ig.psiutils.TypeUtils;
import org.jdom.Element;
import org.jetbrains.annotations.NonNls;
@@ -196,9 +197,6 @@ public class LogStatementGuardedByLogConditionInspectionBase extends BaseInspect
return;
}
final PsiExpression qualifier = methodExpression.getQualifierExpression();
if (qualifier == null) {
return;
}
if (!TypeUtils.expressionHasTypeOrSubtype(qualifier, loggerClassName)) {
return;
}
@@ -240,13 +238,11 @@ public class LogStatementGuardedByLogConditionInspectionBase extends BaseInspect
}
private boolean isLogGuardCheck(@Nullable PsiExpression expression, String logMethodName) {
expression = ParenthesesUtils.stripParentheses(expression);
if (expression instanceof PsiMethodCallExpression) {
final PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression)expression;
final PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
final PsiExpression qualifier = methodExpression.getQualifierExpression();
if (qualifier == null) {
return false;
}
if (!TypeUtils.expressionHasTypeOrSubtype(qualifier, loggerClassName)) {
return false;
}
plugins/InspectionGadgets/test/com/siyeh/igtest/logging/log_statement_guarded_by_log_condition/LogStatementGuardedByLogCondition.java
+1 -1
View File
@@ -5,7 +5,7 @@ public class LogStatementGuardedByLogCondition {
private static final Logger LOG = Logger.getLogger("log");
void guarded(Object object) {
if (LOG.isDebug()) {
if (((LOG.isDebug()))) {
if (true) {
if (true) {
LOG.debug("really expensive logging" + object);