MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

inline method: allow to inline vars ar parameters for negative values (IDEA-154831)

Browse Source
This commit is contained in:
Anna Kozlova
2016-05-26 15:04:44 +03:00
parent 307bae3a27
commit 7ae633eb9f
4 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/java-impl/src/com/intellij/refactoring/inline/InlineMethodProcessor.java
View File

@@ -1148,6 +1148,9 @@ public class InlineMethodProcessor extends BaseRefactoringProcessor {
else if (initializer instanceof PsiLiteralExpression) {
return true;
}
else if (initializer instanceof PsiPrefixExpression && ((PsiPrefixExpression)initializer).getOperand() instanceof PsiLiteralExpression) {
return true;
}
else if (initializer instanceof PsiArrayAccessExpression) {
final PsiExpression arrayExpression = ((PsiArrayAccessExpression)initializer).getArrayExpression();
final PsiExpression indexExpression = ((PsiArrayAccessExpression)initializer).getIndexExpression();

9
java/java-tests/testData/refactoring/inlineMethod/NegativeArguments.java Normal file
View File

@@ -0,0 +1,9 @@
class Test {
void foo(double d1, double d2) {
System.out.println(d1, d2);
}
{
f<caret>oo(-12.0, 12.0);
}
}

6
java/java-tests/testData/refactoring/inlineMethod/NegativeArguments.java.after Normal file
View File

@@ -0,0 +1,6 @@
class Test {
{
System.out.println(-12.0, 12.0);
}
}

4
java/java-tests/testSrc/com/intellij/refactoring/inline/InlineMethodTest.java
View File

@@ -316,6 +316,10 @@ public class InlineMethodTest extends LightRefactoringTestCase {
doTest();
}
public void testNegativeArguments() throws Exception {
doTest();
}
public void testInaccessibleFieldInSuperClass() throws Exception {
doTestConflict("Field <b><code>A.i</code></b> that is used in inlined method is not accessible from call site(s) in method <b><code>B.bar()</code></b>");
}