MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

fixed PY-12717 Improper replacement of the print x, y statement for Py3+

Browse Source
This commit is contained in:
Ekaterina Tuzova
2014-04-28 17:04:39 +04:00
parent 33aeb0b2af
commit 7a8f56ca41
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/quickfix/CompatibilityPrintCallQuickFix.java
+8 -7
View File
@@ -23,9 +23,7 @@ import com.intellij.psi.PsiElement;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.Function;
import com.jetbrains.python.PyBundle;
import com.jetbrains.python.psi.LanguageLevel;
import com.jetbrains.python.psi.PyElementGenerator;
import com.jetbrains.python.psi.PyExpression;
import com.jetbrains.python.psi.*;
import org.jetbrains.annotations.NotNull;
/**
@@ -51,9 +49,9 @@ public class CompatibilityPrintCallQuickFix implements LocalQuickFix {
}
private static void replacePrint(PsiElement expression, PyElementGenerator elementGenerator) {
StringBuilder stringBuilder = new StringBuilder("print(");
PyExpression[] target = PsiTreeUtil.getChildrenOfType(expression, PyExpression.class);
final StringBuilder stringBuilder = new StringBuilder("print(");
final PyFile file = (PyFile)expression.getContainingFile();
final PyExpression[] target = PsiTreeUtil.getChildrenOfType(expression, PyExpression.class);
if (target != null) {
stringBuilder.append(StringUtil.join(target, new Function<PyExpression, String>() {
@Override
@@ -62,9 +60,12 @@ public class CompatibilityPrintCallQuickFix implements LocalQuickFix {
}
}, ", "));
}
stringBuilder.append(")");
expression.replace(elementGenerator.createFromText(LanguageLevel.forElement(expression), PyExpression.class,
stringBuilder.toString()));
final PyFromImportStatement statement = elementGenerator.createFromText(LanguageLevel.forElement(expression), PyFromImportStatement.class,
"from __future__ import print_function");
file.addBefore(statement, file.getStatements().get(0));
}
}
python/testData/inspections/ReplacePrint_after.py
+2
View File
@@ -1 +1,3 @@
from __future__ import print_function
print("foo")