MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 21:11:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

disable lambda -> method ref if resulted methods are not the same (IDEA-134486)

Browse Source
This commit is contained in:
Anna Kozlova
2014-12-18 14:09:45 +01:00
parent 6e761e661f
commit 79da0849e2
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/java-analysis-impl/src/com/intellij/codeInspection/LambdaCanBeMethodReferenceInspection.java
View File

@@ -22,10 +22,7 @@ import com.intellij.openapi.project.Project;
import com.intellij.pom.java.LanguageLevel;
import com.intellij.psi.*;
import com.intellij.psi.codeStyle.JavaCodeStyleManager;
import com.intellij.psi.util.InheritanceUtil;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.psi.util.TypeConversionUtil;
import com.intellij.psi.util.*;
import com.intellij.util.ArrayUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
@@ -110,7 +107,16 @@ public class LambdaCanBeMethodReferenceInspection extends BaseJavaBatchLocalInsp
if (element instanceof PsiMethod && !isSimpleCall(parameters, callExpression, (PsiMethod)element)) {
return null;
}
return callExpression;
if (!(element instanceof PsiMethod)) {
return callExpression;
}
final PsiMethod method = callExpression.resolveMethod();
if (method == null) {
LOG.error(callExpression);
return null;
}
return MethodSignatureUtil.areSignaturesEqual((PsiMethod)element, method) ? callExpression : null;
}
}
finally {

9
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/lambda2methodReference/beforeAmbiguousMethodsDifferentChosenByReferenceAndLambda.java Normal file
View File

@@ -0,0 +1,9 @@
// "Replace lambda with method reference" "false"
import java.util.HashMap;
import java.util.Map;
class Test {
public static void main(Map<Integer, Map<Object, Object>> map) {
map.computeIfAbsent(123, key -> new Hash<caret>Map<>());
}
}