mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
[space] Reduce review list UI lags
Don't reassign icon values to labels because it do some overhead job instead of simple assignment GitOrigin-RevId: ad46bfa43dd2ece90f4e87aea66f88b795c55078
This commit is contained in:
committed by
intellij-monorepo-bot
parent
625da1c6c7
commit
79789a301a
+11
-9
@@ -132,11 +132,13 @@ internal class SpaceReviewListCellRenderer(
|
||||
|
||||
val (reviewRef, messagesCount, _, participantsRef) = value
|
||||
|
||||
val reviewers = participantsRef.resolve().participants?.filter {
|
||||
val participants = participantsRef.resolve().participants
|
||||
|
||||
val reviewers = participants?.filter {
|
||||
it.role == CodeReviewParticipantRole.Reviewer
|
||||
}
|
||||
|
||||
val authors = participantsRef.resolve().participants?.filter {
|
||||
val authors = participants?.filter {
|
||||
it.role == CodeReviewParticipantRole.Author
|
||||
}
|
||||
|
||||
@@ -186,11 +188,9 @@ internal class SpaceReviewListCellRenderer(
|
||||
}
|
||||
|
||||
firstReviewLabel.apply {
|
||||
icon = emptyAvatar
|
||||
configureMemberLabel(firstReviewLabel, reviewers?.firstOrNull()?.user?.resolve())
|
||||
}
|
||||
secondReviewLabel.apply {
|
||||
icon = emptyAvatar
|
||||
configureMemberLabel(secondReviewLabel, reviewers?.secondOrNull()?.user?.resolve())
|
||||
}
|
||||
|
||||
@@ -204,11 +204,13 @@ internal class SpaceReviewListCellRenderer(
|
||||
|
||||
|
||||
private fun configureMemberLabel(label: JLabel, profile: TD_MemberProfile?) {
|
||||
label.toolTipText = ""
|
||||
label.icon = emptyAvatar
|
||||
profile?.let {
|
||||
label.icon = avatarProvider.getIcon(it)
|
||||
label.toolTipText = it.englishFullName() // NON-NLS
|
||||
if (profile != null) {
|
||||
label.icon = avatarProvider.getIcon(profile)
|
||||
label.toolTipText = profile.englishFullName() // NON-NLS
|
||||
}
|
||||
else {
|
||||
label.icon = emptyAvatar
|
||||
label.toolTipText = ""
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user