MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java: Intention that wraps list/set/map with Collections.unmodifiable - don't suggest on the left-hand side of assignment (IDEA-208885)

Browse Source
This commit is contained in:
Pavel Dolgov
2019-03-15 13:15:55 +03:00
parent c8ff86b5ab
commit 79022c29ce
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInsight/intention/impl/WrapWithUnmodifiableAction.java
View File

@@ -97,7 +97,7 @@ public class WrapWithUnmodifiableAction extends BaseIntentionAction {
}
PsiExpression expression = getParentExpression(editor, file);
if (expression != null) {
if (isUnmodifiable(expression)) {
if (PsiUtil.isOnAssignmentLeftHand(expression) || isUnmodifiable(expression)) {
return false;
}
PsiClass psiClass = PsiUtil.resolveClassInClassTypeOnly(expression.getType());

10
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/wrapWithUnmodifiable/beforeLeftSideOfAssignment.java Normal file
View File

@@ -0,0 +1,10 @@
// "Wrap with unmodifiable map" "false"
import java.util.Map;
import java.util.HashMap;
class C {
Map<String, String> map;
{
this.<caret>map = new HashMap<>();
}
}