MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

inspection: more accurate recognition of serialization related members

Browse Source 
for "Unused declaration" inspection

GitOrigin-RevId: 331d66e0c964fabb35886658ff5a0a702cc0ac67
This commit is contained in:
Bas Leijdekkers
2024-06-05 17:39:47 +02:00
committed by intellij-monorepo-bot
parent d93f3a397d
commit 78865dc0a1
3 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
java/java-analysis-impl/src/com/intellij/codeInspection/deadCode/RefSerializationUtil.java
View File

@@ -5,6 +5,7 @@ import com.intellij.codeInspection.reference.RefClass;
import com.intellij.openapi.project.DumbService;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -31,55 +32,68 @@ public final class RefSerializationUtil {
public static boolean isSerializationImplicitlyUsedField(@NotNull UField field) {
String name = field.getName();
if (!CommonClassNames.SERIAL_VERSION_UID_FIELD_NAME.equals(name) && !"serialPersistentFields".equals(name)) return false;
if (!field.isStatic()) return false;
if (CommonClassNames.SERIAL_VERSION_UID_FIELD_NAME.equals(name)) {
if (!PsiTypes.longType().equals(field.getType())) return false;
}
else if ("serialPersistentFields".equals(name)) {
if (field.getVisibility() != UastVisibility.PRIVATE) return false;
if (!(field.getType() instanceof PsiArrayType arrayType) || arrayType.getArrayDimensions() != 1) return false;
PsiType componentType = arrayType.getComponentType();
PsiClass aClass = PsiUtil.resolveClassInClassTypeOnly(componentType);
if (aClass != null && !"java.io.ObjectStreamField".equals(aClass.getQualifiedName())) return false;
}
else {
return false;
}
if (!field.isStatic() || !field.isFinal()) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(field, UClass.class);
return aClass == null || isSerializable(aClass, null);
}
private static boolean isWriteObjectMethod(@NotNull UMethod method, @Nullable RefClass refClass) {
if (!"writeObject".equals(method.getName())) return false;
if (method.isStatic() || method.getVisibility() != UastVisibility.PRIVATE) return false;
List<UParameter> parameters = method.getUastParameters();
if (parameters.size() != 1) return false;
if (!equalsToText(parameters.get(0).getType(), "java.io.ObjectOutputStream")) return false;
if (method.isStatic()) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(method, UClass.class);
return aClass == null || isSerializable(aClass, refClass);
}
private static boolean isReadObjectMethod(@NotNull UMethod method, @Nullable RefClass refClass) {
if (!"readObject".equals(method.getName())) return false;
if (method.isStatic() || method.getVisibility() != UastVisibility.PRIVATE) return false;
List<UParameter> parameters = method.getUastParameters();
if (parameters.size() != 1) return false;
if (!equalsToText(parameters.get(0).getType(), "java.io.ObjectInputStream")) return false;
if (method.isStatic()) return false;
if (!equalsToText(method.getReturnType(), PsiKeyword.VOID)) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(method, UClass.class);
return aClass == null || isSerializable(aClass, refClass);
}
private static boolean isReadObjectNoDataMethod(@NotNull UMethod method, @Nullable RefClass refClass) {
if (!"readObjectNoData".equals(method.getName())) return false;
if (method.isStatic() || method.getVisibility() != UastVisibility.PRIVATE) return false;
if (!method.getUastParameters().isEmpty()) return false;
if (!equalsToText(method.getReturnType(), PsiKeyword.VOID)) return false;
if (method.isStatic()) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(method, UClass.class);
return aClass == null || isSerializable(aClass, refClass);
}
private static boolean isWriteReplaceMethod(@NotNull UMethod method, @Nullable RefClass refClass) {
if (!"writeReplace".equals(method.getName())) return false;
if (method.isStatic()) return false;
if (!method.getUastParameters().isEmpty()) return false;
if (!equalsToText(method.getReturnType(), CommonClassNames.JAVA_LANG_OBJECT)) return false;
if (method.isStatic()) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(method, UClass.class);
return aClass == null || isSerializable(aClass, refClass);
}
private static boolean isReadResolveMethod(@NotNull UMethod method, @Nullable RefClass refClass) {
if (!"readResolve".equals(method.getName())) return false;
if (method.isStatic()) return false;
if (!method.getUastParameters().isEmpty()) return false;
if (!equalsToText(method.getReturnType(), CommonClassNames.JAVA_LANG_OBJECT)) return false;
if (method.isStatic()) return false;
UClass aClass = UDeclarationKt.getContainingDeclaration(method, UClass.class);
return aClass == null || isSerializable(aClass, refClass);
}

3
java/java-tests/testData/inspection/deadCode/serializable/src/Test.java
View File

@@ -1,7 +1,8 @@
public class Test implements java.io.Serializable {
private static final long serialVersionUID = -1062693747706162247L;
private void writeObject(java.io.ObjectOutputStream out) {}
private void readObject(java.io.ObjectInputStream in) {}
public Object writeReplace() { return null; }
public Object readResolve() { return null; }
public void readObjectNoData() {}
private void readObjectNoData() {}
}

2
java/java-tests/testData/inspection/redundantThrow/entryPoint/src/Test.java
View File

@@ -1,3 +1,3 @@
public class Test implements java.io.Serializable {
public void readObject(java.io.ObjectInputStream in) throws Exception {}
private void readObject(java.io.ObjectInputStream in) throws Exception {}
}