MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-8325 Do not reset chunk position if it was parsed

Browse Source
This commit is contained in:
Valentina Kiryushkina
2017-05-15 14:37:54 +03:00
parent 0676702abb
commit 77de45b0fd
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyStringFormatInspection.java
+3 -1
View File
@@ -491,7 +491,9 @@ public class PyStringFormatInspection extends PyInspection {
as(chunks.get(i), PyStringFormatParser.NewStyleSubstitutionChunk.class);
if (chunk != null) {
chunk.setPosition(i);
if (chunk.getPosition() == null) {
chunk.setPosition(i);
}
String mappingKey = inspectNewStyleChunkAndGetMappingKey(chunk);
if (!isProblem()) {
inspectArguments(chunk, mappingKey);
python/testData/inspections/PyStringFormatInspection/TooFewMappingKeys.py
+2
View File
@@ -0,0 +1,2 @@
<warning descr="Too few mapping keys">'Hello, {1}'</warning>.format('World')
<warning descr="Too few mapping keys">'Hello, {} {}!'</warning>.format('World')
python/testSrc/com/jetbrains/python/inspections/PyStringFormatInspectionTest.java
+5
View File
@@ -189,6 +189,11 @@ public class PyStringFormatInspectionTest extends PyTestCase {
doTest();
}
// PY-8325
public void testTooFewMappingKeys() {
doTest();
}
// PY-20599
public void testPy3kAsciiFormatSpecifier() {
runWithLanguageLevel(LanguageLevel.PYTHON35, new Runnable() {