MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-156071 Simple static method renderers are much slower than toString - cache TypeEvaluator result

Browse Source
This commit is contained in:
Egor.Ushakov
2016-05-30 12:47:36 +03:00
parent 102df7c3d1
commit 74ff443db6
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/debugger/impl/src/com/intellij/debugger/engine/evaluation/expression/TypeEvaluator.java
+15 -1
View File
@@ -26,12 +26,19 @@ import com.intellij.debugger.engine.JVMName;
import com.intellij.debugger.engine.evaluation.EvaluateException;
import com.intellij.debugger.engine.evaluation.EvaluateExceptionUtil;
import com.intellij.debugger.engine.evaluation.EvaluationContextImpl;
import com.intellij.reference.SoftReference;
import com.sun.jdi.ClassLoaderReference;
import com.sun.jdi.ReferenceType;
import org.jetbrains.annotations.NotNull;
import java.lang.ref.WeakReference;
public class TypeEvaluator implements Evaluator {
private final JVMName myTypeName;
private WeakReference<ReferenceType> myLastResult;
private WeakReference<ClassLoaderReference> myLastClassLoader;
public TypeEvaluator(@NotNull JVMName typeName) {
myTypeName = typeName;
}
@@ -44,12 +51,19 @@ public class TypeEvaluator implements Evaluator {
* @return ReferenceType in the target VM, with the given fully qualified name
*/
public Object evaluate(EvaluationContextImpl context) throws EvaluateException {
ClassLoaderReference classLoader = context.getClassLoader();
Object lastRes = SoftReference.dereference(myLastResult);
if (lastRes != null && classLoader == SoftReference.dereference(myLastClassLoader)) {
return lastRes;
}
DebugProcessImpl debugProcess = context.getDebugProcess();
String typeName = myTypeName.getName(debugProcess);
final ReferenceType type = debugProcess.findClass(context, typeName, context.getClassLoader());
ReferenceType type = debugProcess.findClass(context, typeName, classLoader);
if (type == null) {
throw EvaluateExceptionUtil.createEvaluateException(DebuggerBundle.message("error.class.not.loaded", typeName));
}
myLastClassLoader = new WeakReference<>(classLoader);
myLastResult = new WeakReference<>(type);
return type;
}