MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

avoid using WolfTheProblemSolver.hasSyntaxErrors is possible, because it isn't designed to be a public API

Browse Source
This commit is contained in:
Sergey Simonchik
2013-11-20 16:39:27 +04:00
parent 0f79597ae1
commit 7459a38ba1
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/execution/DelayedDocumentWatcher.java
+17 -2
View File
@@ -29,6 +29,9 @@ import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Condition;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.problems.WolfTheProblemSolver;
import com.intellij.psi.PsiDocumentManager;
import com.intellij.psi.PsiFile;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.Alarm;
import com.intellij.util.Consumer;
import com.intellij.util.messages.MessageBusConnection;
@@ -128,9 +131,9 @@ public class DelayedDocumentWatcher {
private class MyRunnable implements Runnable {
@Override
public void run() {
WolfTheProblemSolver problemSolver = WolfTheProblemSolver.getInstance(myProject);
for (VirtualFile file : myChangedFiles) {
if (problemSolver.hasSyntaxErrors(file)) {
boolean hasErrors = hasErrors(file);
if (hasErrors) {
// Do nothing, if some changed file has syntax errors.
// This method will be invoked subsequently, when syntax errors are fixed.
return;
@@ -142,4 +145,16 @@ public class DelayedDocumentWatcher {
}
}
private boolean hasErrors(@NotNull VirtualFile file) {
// don't use 'WolfTheProblemSolver.hasSyntaxErrors(file)' if possible
Document document = FileDocumentManager.getInstance().getDocument(file);
if (document != null) {
PsiFile psiFile = PsiDocumentManager.getInstance(myProject).getPsiFile(document);
if (psiFile != null) {
return PsiTreeUtil.hasErrorElements(psiFile);
}
}
return WolfTheProblemSolver.getInstance(myProject).hasSyntaxErrors(file);
}
}