MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

test for "Constant StringBuffer may be String" inspection

Browse Source
This commit is contained in:
Bas Leijdekkers
2012-01-26 14:09:00 +01:00
parent 97cdf4ce8e
commit 73e303d324
4 changed files with 51 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/performance/StringBufferReplaceableByStringInspection.java
+13 -26
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2010 Dave Griffith, Bas Leijdekkers
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,8 +24,7 @@ import com.siyeh.ig.psiutils.TypeUtils;
import com.siyeh.ig.psiutils.VariableAccessUtils;
import org.jetbrains.annotations.NotNull;
public class StringBufferReplaceableByStringInspection
extends BaseInspection {
public class StringBufferReplaceableByStringInspection extends BaseInspection {
@Override
@NotNull
@@ -46,21 +45,17 @@ public class StringBufferReplaceableByStringInspection
return new StringBufferReplaceableByStringBuilderVisitor();
}
private static class StringBufferReplaceableByStringBuilderVisitor
extends BaseInspectionVisitor {
private static class StringBufferReplaceableByStringBuilderVisitor extends BaseInspectionVisitor {
@Override
public void visitLocalVariable(@NotNull PsiLocalVariable variable) {
super.visitLocalVariable(variable);
final PsiCodeBlock codeBlock =
PsiTreeUtil.getParentOfType(variable, PsiCodeBlock.class);
final PsiCodeBlock codeBlock = PsiTreeUtil.getParentOfType(variable, PsiCodeBlock.class);
if (codeBlock == null) {
return;
}
final PsiType type = variable.getType();
if (!TypeUtils.typeEquals(CommonClassNames.JAVA_LANG_STRING_BUFFER,
type) &&
if (!TypeUtils.typeEquals(CommonClassNames.JAVA_LANG_STRING_BUFFER, type) &&
!TypeUtils.typeEquals(CommonClassNames.JAVA_LANG_STRING_BUILDER, type)) {
return;
}
@@ -80,8 +75,7 @@ public class StringBufferReplaceableByStringInspection
if (VariableAccessUtils.variableIsReturned(variable, codeBlock)) {
return;
}
if (VariableAccessUtils.variableIsPassedAsMethodArgument(variable,
codeBlock)) {
if (VariableAccessUtils.variableIsPassedAsMethodArgument(variable, codeBlock)) {
return;
}
if (variableIsModified(variable, codeBlock)) {
@@ -90,16 +84,13 @@ public class StringBufferReplaceableByStringInspection
registerVariableError(variable);
}
public static boolean variableIsModified(PsiVariable variable,
PsiElement context) {
final VariableIsModifiedVisitor visitor =
new VariableIsModifiedVisitor(variable);
public static boolean variableIsModified(PsiVariable variable, PsiElement context) {
final VariableIsModifiedVisitor visitor = new VariableIsModifiedVisitor(variable);
context.accept(visitor);
return visitor.isModified();
}
private static boolean isNewStringBufferOrStringBuilder(
PsiExpression expression) {
private static boolean isNewStringBufferOrStringBuilder(PsiExpression expression) {
if (expression == null) {
return false;
}
@@ -107,16 +98,12 @@ public class StringBufferReplaceableByStringInspection
return true;
}
else if (expression instanceof PsiMethodCallExpression) {
final PsiMethodCallExpression methodCallExpression =
(PsiMethodCallExpression)expression;
if (!VariableIsModifiedVisitor.isStringBufferUpdate(
methodCallExpression)) {
final PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression)expression;
if (!VariableIsModifiedVisitor.isStringBufferUpdate(methodCallExpression)) {
return false;
}
final PsiReferenceExpression methodExpression =
methodCallExpression.getMethodExpression();
final PsiExpression qualifier =
methodExpression.getQualifierExpression();
final PsiReferenceExpression methodExpression = methodCallExpression.getMethodExpression();
final PsiExpression qualifier = methodExpression.getQualifierExpression();
return isNewStringBufferOrStringBuilder(qualifier);
}
return false;
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/constant_string_buffer_may_be_string/StringBufferReplaceableByString.java
+11
View File
@@ -0,0 +1,11 @@
package com.siyeh.igtest.performance.constant_string_buffer_may_be_string;
public class StringBufferReplaceableByString {
StringBuilder foo() {
StringBuilder builder = new StringBuilder("asdfasdfasdf");
StringBuffer buffer = new StringBuffer("test");
StringBuilder result = new StringBuilder("return");
return result;
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/constant_string_buffer_may_be_string/expected.xml
+16
View File
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
<problem>
<file>StringBufferReplaceableByString.java</file>
<line>6</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Constant StringBuffer may be String</problem_class>
<description>Constant StringBuffer &lt;code&gt;builder&lt;/code&gt; may be declared as String #loc</description>
</problem>
<problem>
<file>StringBufferReplaceableByString.java</file>
<line>7</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Constant StringBuffer may be String</problem_class>
<description>Constant StringBuffer &lt;code&gt;buffer&lt;/code&gt; may be declared as String #loc</description>
</problem>
</problems>
plugins/InspectionGadgets/testsrc/com/siyeh/ig/performance/StringBufferReplaceableByStringInspectionTest.java
+11
View File
@@ -0,0 +1,11 @@
package com.siyeh.ig.performance;
import com.siyeh.ig.IGInspectionTestCase;
public class StringBufferReplaceableByStringInspectionTest extends IGInspectionTestCase {
public void test() throws Exception {
doTest("com/siyeh/igtest/performance/constant_string_buffer_may_be_string",
new StringBufferReplaceableByStringInspection());
}
}