MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

NullParameterConstraintChecker#checkMethodParameters remove isOnTheFly parameter

Browse Source
This commit is contained in:
Dmitry Batkovich
2016-10-10 11:48:28 +03:00
parent c844054768
commit 737540dd4f
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/DataFlowInspectionBase.java
+1 -1
View File
@@ -146,7 +146,7 @@ public class DataFlowInspectionBase extends BaseJavaBatchLocalInspectionTool {
private void analyzeNullLiteralMethodArguments(PsiMethod method, ProblemsHolder holder, boolean isOnTheFly) {
if (REPORT_NULLS_PASSED_TO_NOT_NULL_PARAMETER && isOnTheFly) {
for (PsiParameter parameter : NullParameterConstraintChecker.checkMethodParameters(method, true)) {
for (PsiParameter parameter : NullParameterConstraintChecker.checkMethodParameters(method)) {
holder.registerProblem(parameter.getNameIdentifier(),
InspectionsBundle.message("dataflow.method.fails.with.null.argument"),
ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/NullParameterConstraintChecker.java
+2 -2
View File
@@ -54,7 +54,7 @@ class NullParameterConstraintChecker extends DataFlowRunner {
}
@NotNull
static PsiParameter[] checkMethodParameters(PsiMethod method, boolean isOnTheFly) {
static PsiParameter[] checkMethodParameters(PsiMethod method) {
if (method.getBody() == null) return PsiParameter.EMPTY_ARRAY;
final Collection<PsiParameter> nullableParameters = new SmartList<>();
@@ -70,7 +70,7 @@ class NullParameterConstraintChecker extends DataFlowRunner {
}
if (nullableParameters.isEmpty()) return PsiParameter.EMPTY_ARRAY;
final NullParameterConstraintChecker checker = new NullParameterConstraintChecker(nullableParameters, isOnTheFly);
final NullParameterConstraintChecker checker = new NullParameterConstraintChecker(nullableParameters, true);
checker.analyzeMethod(method.getBody(), new StandardInstructionVisitor());
return checker.myPossiblyViolatedParameters.toArray(new PsiParameter[checker.myPossiblyViolatedParameters.size()]);