IG: remove no longer useful inspection

2026-09-27 10:03:11 +07:00 · 2016-06-30 14:50:50 +02:00
parent 5cb12c93fb
commit 735ce3d0a6
7 changed files with 0 additions and 162 deletions
@@ -196,9 +196,6 @@
                     key="non.final.field.compareto.display.name" groupBundle="messages.InspectionsBundle"
                     groupKey="group.names.probable.bugs" enabledByDefault="false" level="WARNING"
                     implementationClass="com.siyeh.ig.bugs.CompareToUsesNonFinalVariableInspection"/>
-    <localInspection groupPath="Java" language="JAVA" shortName="CovariantCompareTo" bundle="com.siyeh.InspectionGadgetsBundle" key="covariant.compareto.display.name"
-                     groupBundle="messages.InspectionsBundle" groupKey="group.names.probable.bugs" enabledByDefault="false" level="WARNING"
-                     implementationClass="com.siyeh.ig.bugs.CovariantCompareToInspection"/>
    <localInspection groupPath="Java" language="JAVA" shortName="CovariantEquals" bundle="com.siyeh.InspectionGadgetsBundle" key="covariant.equals.display.name"
                     groupBundle="messages.InspectionsBundle" groupKey="group.names.probable.bugs" enabledByDefault="false" level="WARNING"
                     implementationClass="com.siyeh.ig.bugs.CovariantEqualsInspection"/>
@@ -62,8 +62,6 @@ collection.added.to.self.display.name=Collection added to self
 collection.added.to.self.problem.descriptor=''{0}()'' called on collection <code>#ref</code> with itself as argument #loc
 non.final.field.compareto.display.name=Non-final field referenced in 'compareTo()'
 non.final.field.compareto.problem.descriptor=Non-final field <code>#ref</code> accessed in 'compareTo()' #loc
-covariant.compareto.display.name=Covariant 'compareTo()'
-covariant.compareto.problem.descriptor=<code>#ref()</code> should take 'Object' as its argument #loc
 covariant.equals.display.name=Covariant 'equals()'
 covariant.equals.problem.descriptor=<code>#ref()</code> should take 'Object' as its argument #loc
 empty.class.initializer.display.name=Empty class initializer
@@ -1,105 +0,0 @@
-/*
- * Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package com.siyeh.ig.bugs;
-
-import com.intellij.openapi.project.Project;
-import com.intellij.psi.*;
-import com.intellij.psi.search.GlobalSearchScope;
-import com.intellij.psi.util.TypeConversionUtil;
-import com.siyeh.HardcodedMethodConstants;
-import com.siyeh.InspectionGadgetsBundle;
-import com.siyeh.ig.BaseInspection;
-import com.siyeh.ig.BaseInspectionVisitor;
-import com.siyeh.ig.psiutils.MethodUtils;
-import com.siyeh.ig.psiutils.TypeUtils;
-import org.jetbrains.annotations.NotNull;
-
-public class CovariantCompareToInspection extends BaseInspection {
-
-  @Override
-  @NotNull
-  public String getDisplayName() {
-    return InspectionGadgetsBundle.message("covariant.compareto.display.name");
-  }
-
-  @Override
-  @NotNull
-  public String buildErrorString(Object... infos) {
-    return InspectionGadgetsBundle.message("covariant.compareto.problem.descriptor");
-  }
-
-  @Override
-  public BaseInspectionVisitor buildVisitor() {
-    return new CovariantCompareToVisitor();
-  }
-
-  private static class CovariantCompareToVisitor extends BaseInspectionVisitor {
-
-    @Override
-    public void visitMethod(@NotNull PsiMethod method) {
-      final String name = method.getName();
-      if (!HardcodedMethodConstants.COMPARE_TO.equals(name)) {
-        return;
-      }
-      if (!method.hasModifierProperty(PsiModifier.PUBLIC)) {
-        return;
-      }
-      final PsiParameterList parameterList = method.getParameterList();
-      if (parameterList.getParametersCount() != 1) {
-        return;
-      }
-      final PsiParameter[] parameters = parameterList.getParameters();
-      final PsiType paramType = parameters[0].getType();
-      if (TypeUtils.isJavaLangObject(paramType)) {
-        return;
-      }
-      final PsiClass aClass = method.getContainingClass();
-      if (aClass == null) {
-        return;
-      }
-      final PsiMethod[] methods = aClass.findMethodsByName(HardcodedMethodConstants.COMPARE_TO, false);
-      final Project project = method.getProject();
-      final JavaPsiFacade psiFacade = JavaPsiFacade.getInstance(project);
-      final GlobalSearchScope scope = method.getResolveScope();
-      final PsiClass comparableClass = psiFacade.findClass(CommonClassNames.JAVA_LANG_COMPARABLE, scope);
-      PsiType substitutedTypeParam = null;
-      if (comparableClass != null && comparableClass.getTypeParameters().length == 1) {
-        final PsiSubstitutor superSubstitutor = TypeConversionUtil.getClassSubstitutor(comparableClass, aClass, PsiSubstitutor.EMPTY);
-        //null iff aClass is not inheritor of comparableClass
-        if (superSubstitutor != null) {
-           substitutedTypeParam = superSubstitutor.substitute(comparableClass.getTypeParameters()[0]);
-        }
-      }
-      for (PsiMethod compareToMethod : methods) {
-        if (isNonVariantCompareTo(compareToMethod, substitutedTypeParam)) {
-          return;
-        }
-      }
-      registerMethodError(method);
-    }
-
-    private static boolean isNonVariantCompareTo(PsiMethod method, PsiType substitutedTypeParam) {
-      final PsiClassType objectType = TypeUtils.getObjectType(method);
-      if (MethodUtils.methodMatches(method, null, PsiType.INT, HardcodedMethodConstants.COMPARE_TO, objectType)) {
-        return true;
-      }
-      if (substitutedTypeParam == null) {
-        return false;
-      }
-      return MethodUtils.methodMatches(method, null, PsiType.INT, HardcodedMethodConstants.COMPARE_TO, substitutedTypeParam);
-    }
-  }
-}
@@ -1,10 +0,0 @@
-<html>
-<body>
-Reports a class having a <b>compareTo()</b>
-method taking an argument other than <b>java.lang.Object</b>, if the class does not have a <b>compareTo()</b> method
-which does take <b>java.lang.Object</b> as its argument. Normally, this is a mistake.
-<!-- tooltip end -->
-<p>
-
-</body>
-</html>
@@ -1,11 +0,0 @@
-import java.lang.Comparable;
-
-class Foo implements Comparable<Foo> {
-  public int compareTo(Foo o) {
-    return 0;  //To change body of implemented methods use File | Settings | File Templates.
-  }
-
-  public int compareTo(String o) {
-    return 0;  //To change body of implemented methods use File | Settings | File Templates.
-  }
-}
@@ -1,2 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<problems/>
@@ -1,29 +0,0 @@
-/*
- * Copyright 2000-2012 JetBrains s.r.o.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package com.siyeh.ig.bugs;
-
-import com.siyeh.ig.IGInspectionTestCase;
-
-public class CovariantCompareToInspectionTest extends IGInspectionTestCase {
-
-  public void testSimple() throws Exception {
-    doTest();
-  }
-
-  private void doTest() throws Exception {
-    doTest("com/siyeh/igtest/bugs/covariantCompareTo/" + getTestName(true), new CovariantCompareToInspection());
-  }
-}