MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-intentions] IDEA-356722 "Extract side effects" action should not be offered in for loop increment

Browse Source 
GitOrigin-RevId: 51d2d36362df6e5aa16c765cd7d089b8c5fc5c7e
This commit is contained in:
Tagir Valeev
2024-11-28 17:43:28 +00:00
committed by intellij-monorepo-bot
parent ed84affe00
commit 734fecb1ac
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightUtil.java
+7 -5
View File
@@ -51,8 +51,8 @@ import com.intellij.psi.search.GlobalSearchScope;
import com.intellij.psi.templateLanguages.OuterLanguageElement;
import com.intellij.psi.tree.IElementType;
import com.intellij.psi.tree.TokenSet;
import com.intellij.psi.util.InheritanceUtil;
import com.intellij.psi.util.*;
import com.intellij.psi.util.InheritanceUtil;
import com.intellij.refactoring.util.RefactoringChangeUtil;
import com.intellij.ui.ColorUtil;
import com.intellij.ui.NewUI;
@@ -69,8 +69,8 @@ import one.util.streamex.StreamEx;
import org.jetbrains.annotations.*;
import java.awt.*;
import java.util.List;
import java.util.*;
import java.util.List;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Function;
@@ -1867,9 +1867,11 @@ public final class HighlightUtil {
List<IntentionAction> registrar = new ArrayList<>();
HighlightFixUtil.registerFixesForExpressionStatement(statement, registrar);
QuickFixAction.registerQuickFixActions(error, null, registrar);
IntentionAction action = PriorityIntentionActionWrapper
.lowPriority(getFixFactory().createDeleteSideEffectAwareFix(expressionStatement));
error.registerFix(action, null, null, null, null);
if (expressionStatement.getParent() instanceof PsiCodeBlock) {
IntentionAction action = PriorityIntentionActionWrapper
.lowPriority(getFixFactory().createDeleteSideEffectAwareFix(expressionStatement));
error.registerFix(action, null, null, null, null);
}
}
return error;
}
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/deleteSideEffectsAware/beforeForUpdate.java
+8
View File
@@ -0,0 +1,8 @@
// "Extract side effects as an 'if' statement" "false"
class Z {
void z() {
for (int i = 0; ; (i < 100) ?<caret> i++ : i--) {
}
}
}