MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

do not report unused imports for files with disabled highlighting (IDEA-76478)

Browse Source
This commit is contained in:
anna
2011-11-13 18:58:29 +01:00
parent c2f6991ffd
commit 7174066876
3 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInsight/daemon/impl/PostHighlightingPass.java
+1 -1
View File
@@ -257,7 +257,7 @@ public class PostHighlightingPass extends TextEditorHighlightingPass {
}
}
}
if (unusedImportEnabled && myFile instanceof PsiJavaFile) {
if (unusedImportEnabled && myFile instanceof PsiJavaFile && HighlightLevelUtil.shouldHighlight(myFile)) {
PsiImportList importList = ((PsiJavaFile)myFile).getImportList();
if (importList != null) {
final PsiImportStatementBase[] imports = importList.getAllImportStatements();
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/unusedImports/WithHighlightingOff.java
+5
View File
@@ -0,0 +1,5 @@
import javax.swing.JComponent;
class Test{
JComponent component;
}
java/java-tests/testSrc/com/intellij/codeInsight/daemon/UnusedImportsTest.java
+17
View File
@@ -1,7 +1,10 @@
package com.intellij.codeInsight.daemon;
import com.intellij.codeInsight.daemon.impl.analysis.FileHighlighingSetting;
import com.intellij.codeInsight.daemon.impl.analysis.HighlightingSettingsPerFile;
import com.intellij.codeInspection.LocalInspectionTool;
import com.intellij.codeInspection.unusedImport.UnusedImportLocalInspection;
import com.intellij.psi.PsiFile;
public class UnusedImportsTest extends DaemonAnalyzerTestCase {
private static final String BASE_PATH = "/codeInsight/daemonCodeAnalyzer/unusedImports";
@@ -13,6 +16,20 @@ public class UnusedImportsTest extends DaemonAnalyzerTestCase {
public void test1() throws Exception { doTest(); }
public void test2() throws Exception { doTest(); }
public void testWithHighlightingOff() throws Exception {
configureByFile(BASE_PATH + "/" + getTestName(false) + ".java");
final PsiFile file = getFile();
final HighlightingSettingsPerFile settingsPerFile = HighlightingSettingsPerFile.getInstance(myProject);
final FileHighlighingSetting oldSetting = settingsPerFile.getHighlightingSettingForRoot(file);
try {
settingsPerFile.setHighlightingSettingForRoot(file, FileHighlighingSetting.NONE);
doDoTest(true, false, false);
}
finally {
settingsPerFile.setHighlightingSettingForRoot(file, oldSetting);
}
}
public void testUnclosed() throws Exception { doTest(); }